Command-line sdkmanager needs better error if root dir can't be found [150942306]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 6, 2020 04:37PM

If you have the command-line tools unzipped in an unexpected place and don't specify --sdk_root, you get an uninformative error message:
$ ./sdkmanager --list
Warning: Could not create settings
java.lang.IllegalArgumentException
at com.android.sdklib.tool.sdkmanager.SdkManagerCliSettings.<init>(SdkManagerCliSettings.java:428)
at com.android.sdklib.tool.sdkmanager.SdkManagerCliSettings.createSettings(SdkManagerCliSettings.java:152)
at com.android.sdklib.tool.sdkmanager.SdkManagerCliSettings.createSettings(SdkManagerCliSettings.java:134)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:57)
at com.android.sdklib.tool.sdkmanager.SdkManagerCli.main(SdkManagerCli.java:48)
Usage:
sdkmanager [--uninstall] [<common args>] [--package_file=<file>] [<packages>...]
etc.

We should say what the problem is.

Comments

jb...@google.com <jb...@google.com> #2Mar 24, 2020 05:05PM

This is being frequently reported, including externally. Raise priority.

jb...@google.com <jb...@google.com> #3Mar 24, 2020 05:11PM

I will try to address this and related bugs (150946939, 150943631, 150944411) starting later today.

jb...@google.com <jb...@google.com> #4Apr 27, 2020 11:54PM

Marked as fixed.

Fix is checked in, but probably won't be out until the release after the upcoming one.

ga...@gmail.com <ga...@gmail.com> #5Jun 16, 2020 05:38PM

With 2.0 being out this does not only affect manual downloads. The SDK Manager in Android Studio unpacks it into cmdline-tools/latest/tools and cmdline-tools/2.0/tools instead of cmdline-tools/1.0. This is the opposite of having one directory too much instead of one less.

Here is a tree view of $ANDROID_HOME/cmdline-tools:

├── 1.0
│   ├── NOTICE.txt
│   ├── bin
│   │   ├── apkanalyzer
│   │   ├── avdmanager
│   │   ├── lint
│   │   ├── screenshot2
│   │   └── sdkmanager
│   ├── lib
│   │   └── ...
│   ├── package.xml
│   └── source.properties
├── 2.0
│   ├── _codesign
│   │   └── filelist
│   ├── package.xml
│   └── tools
│       ├── NOTICE.txt
│       ├── bin
│       │   ├── apkanalyzer
│       │   ├── avdmanager
│       │   ├── lint
│       │   ├── screenshot2
│       │   └── sdkmanager
│       ├── lib
│       │   └── ...
│       └── source.properties
└── latest
    ├── _codesign
    │   └── filelist
    ├── package.xml
    └── tools
        ├── NOTICE.txt
        ├── bin
        │   ├── apkanalyzer
        │   ├── avdmanager
        │   ├── lint
        │   ├── screenshot2
        │   └── sdkmanager
        ├── lib
        │   └── ...
        └── source.properties

515 directories, 265 files

This means that the 2.0 and latest install by Android Studio are broken.

Message last modified on Jun 16, 2020 05:39PM

jb...@google.com <jb...@google.com> #6Jun 17, 2020 03:08AM

It looks like this is a problem on mac only.

jb...@google.com <jb...@google.com> #7Jun 17, 2020 03:15AM

I filed a separate bug for this: 159176695.

Issue 150942306