Deprecate Container [151407926]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Mar 13, 2020 10:50AM

Container -> Box, then deprecate Container, then remove it

Comments

ap...@google.com <ap...@google.com> #2Mar 13, 2020 04:58PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Mar 13, 2020 05:05PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

ap...@google.com <ap...@google.com> #4Mar 13, 2020 05:11PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5ea860c07d53546b91d8f346ca3f38f1716b5119
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 11:44:25 2020

Remove Containers from demos, samples and ui benchmarks

All usages of the Container from module-sample and module-demo and intergratioin-test/benchmarks were removed

Bug: 151407926
Test: all tests should pass, also checked demos and those are fine
Change-Id: Ife0b0b2c9665b0641ecbd7c79e24672dd2375a18

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/SpacingBenchmark.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/TrailingLambdaBenchmark.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/core/OnPositionedBenchmark.kt
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/core/WithConstraintsBenchmark.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/core/SimpleRadioButton4TestCase.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/framework/VectorAssetTestCase.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/StateAnimationWithInterruptionsDemo.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/StateBasedRippleDemo.kt
M ui/ui-animation/samples/src/main/java/androidx/ui/animation/samples/AnimatedValueSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ScrollerSamples.kt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/MultipleCollect.kt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/SemanticsL1.kt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/VectorGraphicsDemo.kt
M ui/ui-framework/samples/src/main/java/androidx/ui/framework/samples/LayoutSample.kt
M ui/ui-framework/samples/src/main/java/androidx/ui/framework/samples/PainterSample.kt
M ui/ui-material/integration-tests/material-demos/src/main/java/androidx/ui/material/demos/ElevationDemo.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/DrawerSamples.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/TabSamples.kt
M ui/ui-text/integration-tests/text-demos/src/main/java/androidx/ui/text/demos/ComposeVariousInputField.kt

https://android-review.googlesource.com/1256669

ap...@google.com <ap...@google.com> #5Mar 13, 2020 05:39PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 201726d9348883ad73a9df5d7a9002a1fb02f095
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 14:03:54 2020

Replace Container with Box for material components

Bug: 151407926
Test: should pass
Change-Id: I6a30fa9d9786f37a9e67f34bd9181e720aad565c

M ui/ui-material/src/androidTest/java/androidx/ui/material/AppBarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/DrawerTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ElevationOverlayTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ListItemTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RippleEffectTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/FloatingActionButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt

https://android-review.googlesource.com/1258439

ap...@google.com <ap...@google.com> #6Mar 13, 2020 06:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0be5312f0d370a612a28f9a26342442ce5256294
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 10:48:32 2020

Remove Container usages from compose becnhmarks

Bug: 151407926
Test: this is benchmark tests, should behave the same
Change-Id: I953ed9443d7dabb58d5d4218610a717a97e70a35

M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/ComposeBenchmark.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/deeptree/DeepTree.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/siblings/SiblingManagement.kt

https://android-review.googlesource.com/1256667

ap...@google.com <ap...@google.com> #7Mar 13, 2020 07:04PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 1f54c325553fb3cc04e4e2fcff9bdf6f439804ad
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:33:29 2020

Remove Container usage from ui-tooling

Bug: 151407926
Test: this is test
Change-Id: I37dc960e20a165bdf7082d879bff05fa32b8d0f2

M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt

https://android-review.googlesource.com/1258442

ap...@google.com <ap...@google.com> #8Mar 17, 2020 09:43AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ea174348453d73852c08c096ba22c4e36f748daa
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:59:19 2020

Deprecate Container

This CL removed usages in ui-layout and deprecates container.

Decided with Mihai to leave internal copy of Container for ui-layout tests for now

RelNote: Container has been deprecated. Use Box instead.

Bug:151407926
Test: all tests should pass
Change-Id: I675ced9614fad98dfb90c0ad37583648766cb089

M ui/ui-layout/api/0.1.0-dev07.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev07.txt
M ui/ui-layout/api/restricted_current.txt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AlignTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AspectRatioModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ContainerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ExpandedModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlexTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlowTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutPaddingTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/OnPositionedTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SizeModifiersTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SpacerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/StackTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TableTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/DpConstraints.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Intrinsic.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Spacer.kt

https://android-review.googlesource.com/1258381

ma...@google.com <ma...@google.com> Mar 17, 2020 09:44AM

Marked as fixed.

ap...@google.com <ap...@google.com> #9May 1, 2020 05:14PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dec45dc30a6cc8b1d8b344c8038db56020bad9ea
Author: Matvei Malkov <malkov@google.com>
Date: Fri May 01 17:06:31 2020

Remove Container

After Container was deprecated, few releases have passed, so it's time to delete it completely

Change-Id: Ibbc2b13b68d04a708211e6477a7e4fbd13f34ac6
Relnote: Container has been removed. Use Box instead
Fixes: 151407926
Test: n/a

M ui/ui-layout/api/0.1.0-dev11.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev11.txt
M ui/ui-layout/api/restricted_current.txt
D ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt

https://android-review.googlesource.com/1298866