Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com <ap...@google.com> #3
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com <ap...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 201726d9348883ad73a9df5d7a9002a1fb02f095
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 14:03:54 2020
Replace Container with Box for material components
Bug: 151407926
Test: should pass
Change-Id: I6a30fa9d9786f37a9e67f34bd9181e720aad565c
M ui/ui-material/src/androidTest/java/androidx/ui/material/AppBarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/DrawerTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ElevationOverlayTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ListItemTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RippleEffectTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/FloatingActionButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
https://android-review.googlesource.com/1258439
Branch: androidx-master-dev
commit 201726d9348883ad73a9df5d7a9002a1fb02f095
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 14:03:54 2020
Replace Container with Box for material components
Bug: 151407926
Test: should pass
Change-Id: I6a30fa9d9786f37a9e67f34bd9181e720aad565c
M ui/ui-material/src/androidTest/java/androidx/ui/material/AppBarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/DrawerTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ElevationOverlayTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ListItemTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RippleEffectTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/Button.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Drawer.kt
M ui/ui-material/src/main/java/androidx/ui/material/FloatingActionButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/ListItem.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0be5312f0d370a612a28f9a26342442ce5256294
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 10:48:32 2020
Remove Container usages from compose becnhmarks
Bug: 151407926
Test: this is benchmark tests, should behave the same
Change-Id: I953ed9443d7dabb58d5d4218610a717a97e70a35
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/ComposeBenchmark.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/deeptree/DeepTree.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/siblings/SiblingManagement.kt
https://android-review.googlesource.com/1256667
Branch: androidx-master-dev
commit 0be5312f0d370a612a28f9a26342442ce5256294
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 10:48:32 2020
Remove Container usages from compose becnhmarks
Bug: 151407926
Test: this is benchmark tests, should behave the same
Change-Id: I953ed9443d7dabb58d5d4218610a717a97e70a35
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/ComposeBenchmark.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/deeptree/DeepTree.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/siblings/SiblingManagement.kt
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1f54c325553fb3cc04e4e2fcff9bdf6f439804ad
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:33:29 2020
Remove Container usage from ui-tooling
Bug: 151407926
Test: this is test
Change-Id: I37dc960e20a165bdf7082d879bff05fa32b8d0f2
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
https://android-review.googlesource.com/1258442
Branch: androidx-master-dev
commit 1f54c325553fb3cc04e4e2fcff9bdf6f439804ad
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:33:29 2020
Remove Container usage from ui-tooling
Bug: 151407926
Test: this is test
Change-Id: I37dc960e20a165bdf7082d879bff05fa32b8d0f2
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
ap...@google.com <ap...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-master-dev
commit ea174348453d73852c08c096ba22c4e36f748daa
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:59:19 2020
Deprecate Container
This CL removed usages in ui-layout and deprecates container.
Decided with Mihai to leave internal copy of Container for ui-layout tests for now
RelNote: Container has been deprecated. Use Box instead.
Bug:151407926
Test: all tests should pass
Change-Id: I675ced9614fad98dfb90c0ad37583648766cb089
M ui/ui-layout/api/0.1.0-dev07.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev07.txt
M ui/ui-layout/api/restricted_current.txt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AlignTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AspectRatioModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ContainerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ExpandedModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlexTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlowTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutPaddingTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/OnPositionedTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SizeModifiersTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SpacerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/StackTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TableTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/DpConstraints.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Intrinsic.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Spacer.kt
https://android-review.googlesource.com/1258381
Branch: androidx-master-dev
commit ea174348453d73852c08c096ba22c4e36f748daa
Author: Matvei Malkov <malkov@google.com>
Date: Fri Mar 13 16:59:19 2020
Deprecate Container
This CL removed usages in ui-layout and deprecates container.
Decided with Mihai to leave internal copy of Container for ui-layout tests for now
RelNote: Container has been deprecated. Use Box instead.
Bug:151407926
Test: all tests should pass
Change-Id: I675ced9614fad98dfb90c0ad37583648766cb089
M ui/ui-layout/api/0.1.0-dev07.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev07.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev07.txt
M ui/ui-layout/api/restricted_current.txt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AlignTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/AspectRatioModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ContainerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/ExpandedModifierTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlexTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/FlowTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutPaddingTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/LayoutTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/OnPositionedTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SizeModifiersTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/SpacerTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/StackTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TableTest.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/DpConstraints.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Intrinsic.kt
M ui/ui-layout/src/main/java/androidx/ui/layout/Spacer.kt
ma...@google.com <ma...@google.com>
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-master-dev
commit dec45dc30a6cc8b1d8b344c8038db56020bad9ea
Author: Matvei Malkov <malkov@google.com>
Date: Fri May 01 17:06:31 2020
Remove Container
After Container was deprecated, few releases have passed, so it's time to delete it completely
Change-Id: Ibbc2b13b68d04a708211e6477a7e4fbd13f34ac6
Relnote: Container has been removed. Use Box instead
Fixes: 151407926
Test: n/a
M ui/ui-layout/api/0.1.0-dev11.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev11.txt
M ui/ui-layout/api/restricted_current.txt
D ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt
https://android-review.googlesource.com/1298866
Branch: androidx-master-dev
commit dec45dc30a6cc8b1d8b344c8038db56020bad9ea
Author: Matvei Malkov <malkov@google.com>
Date: Fri May 01 17:06:31 2020
Remove Container
After Container was deprecated, few releases have passed, so it's time to delete it completely
Change-Id: Ibbc2b13b68d04a708211e6477a7e4fbd13f34ac6
Relnote: Container has been removed. Use Box instead
Fixes: 151407926
Test: n/a
M ui/ui-layout/api/0.1.0-dev11.txt
M ui/ui-layout/api/current.txt
M ui/ui-layout/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-layout/api/public_plus_experimental_current.txt
M ui/ui-layout/api/restricted_0.1.0-dev11.txt
M ui/ui-layout/api/restricted_current.txt
D ui/ui-layout/src/main/java/androidx/ui/layout/Container.kt
Description