BottomSheetDialogFragment does not properly display its view [151652127]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Mar 16, 2020 08:01PM

Component used: Fragment
Version used: 1.3.0-alpha02
Devices/Android versions reproduced on: all

The changes introduced into DialogFragment in version 1.3.0-alpha02 are causing BottomSheetDialogFragment to not be display properly. Instead of the Dialog being full screen width, it is a centered, floating dialog.

This reason for this is the recent changes use observe() with a LifecycleObserver on the DialogFragment's viewLifecycleOwnerLiveData, and calls setContentView in the observer's onChanged, instead of in the deprecated onActivityCreated(). But because it uses observe, the observer is not active until the LifecycleOwner is started, so onChanged is not called until the Dialog is started, which means it is shown before setContentView is called.

Instead of observe, the viewLifecycleOwnereLiveData should use observeForever() so that the observer can receive events before the LifecycleOwner is started.

Comments

ap...@google.com <ap...@google.com> #2Mar 16, 2020 09:16PM

Jeremy, is this still an issue? I think the problem was that you had two transitions targeting the same View for the same action (e.g. two Slide() transitions).

ap...@google.com <ap...@google.com> #3Mar 18, 2020 05:33PM

I have a similar issue with plain AnimatorSet:

set.start()
set.pause()
set.setCurrentPlayTime(100)
set.setCurrentPlayTime(0)
set.setCurrentPlayTime(100)
set.resume()

doesn't play animation in resume().

jb...@google.com <jb...@google.com> #4Mar 18, 2020 05:41PM

Marked as fixed.

Should clarify that if I filter out setCurrentPlayTime(0) (or replace it with setCurrentPlayTime(1)) it works well.

Also even with setCurrentPlayTime(0), onAnimationEnd is notified with correct delay (as if the animation has played).

Issue 151652127

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 16, 2020 09:16PM

ap...@google.com <ap...@google.com> #3Mar 18, 2020 05:33PM

jb...@google.com <jb...@google.com> #4Mar 18, 2020 05:41PM

Add comment

Issue metadata