Improve viewLifecycleOwner lint message for DialogFragments. [151765086]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Mar 18, 2020 03:48PM

Component used: Fragment
Version used: 1.2.2
Devices/Android versions reproduced on: Pixel 3 running Android 10

If a DialogFragment doesn't return a View in onCreateView then onViewCreated isn't called. In such case if one tries to use viewLifecycleOwner he's probably doing it in onCreateDialog or earlier. But using viewLifecycleOwner isn't possible before view is created. There is a lint error with a message that explains that. But this message doesn't take into account that it's a DialogFragment which should be treated differently (viewLifecycleOwner shouldn't be used). It would be good to detect that viewLifecycleOwner is being used in DialogFragment and show a better message.

Comments

il...@google.com <il...@google.com> Mar 18, 2020 05:01PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Mar 23, 2020 09:16PM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

an...@google.com <an...@google.com> #3Mar 24, 2020 12:10AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6552735953321984/#/history/all)
Created: 2020-03-24 00:08:58.917870+00:00
Changes: aosp/1266061

jb...@google.com <jb...@google.com> #4Mar 24, 2020 04:32PM

Marked as fixed.

This has been addressed internally and will be available in the Fragment 1.2.4 and 1.3.0-alpha03 releases.

il...@google.com <il...@google.com> #5Mar 24, 2020 04:43PM

Specifically, because DialogFragments cannot go onto the FragmentManager back stack, it makes no effective difference on whether you use this or viewLifecycleOwner for a DialogFragment, so the Lint check to verify that you're using the right one is unnecessary.

Issue 151765086