Fixed
Status Update
Comments
so...@google.com <so...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
no...@google.com <no...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
dj...@gmail.com <dj...@gmail.com> #4
deleted
si...@google.com <si...@google.com>
no...@google.com <no...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
si...@google.com <si...@google.com>
no...@google.com <no...@google.com> #6
On the second thought, now I think returning Boolean is a good idea here since that enforces developers to process the text synchronously, e.g. validation.
It is good to pass controller for hiding keyboard in some way.
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 0f2b8d58ca07aa8b1bf0c01f4af822cbae3b26d6
Author: Seigo Nonaka <nona@google.com>
Date: Mon Apr 27 15:15:52 2020
Add SoftwareKeyboardController
SoftwareKeyboardController is delivered to developer when
new text input session has established via onTextInputStarted callback.
Bug: 151860051
Bug: 150194952
Test: Manually done
Test: TreeHugger
Relnote: "Now it is possible to hide/show software keyboard by using
SoftwareKeyboardController which is delivered by onTextInputStarted
callback"
Change-Id: I8dc44f64d4f457339364b9624c0b3e946cdf01b3
M ui/ui-foundation/api/0.1.0-dev11.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev11.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TextLayoutDirectionModifierTest.kt
M ui/ui-text-core/api/0.1.0-dev11.txt
M ui/ui-text-core/api/current.txt
M ui/ui-text-core/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text-core/api/public_plus_experimental_current.txt
M ui/ui-text-core/api/restricted_0.1.0-dev11.txt
M ui/ui-text-core/api/restricted_current.txt
A ui/ui-text-core/src/main/java/androidx/ui/text/SoftwareKeyboardController.kt
M ui/ui-text/api/0.1.0-dev11.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev11.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt
https://android-review.googlesource.com/1296996
Branch: androidx-master-dev
commit 0f2b8d58ca07aa8b1bf0c01f4af822cbae3b26d6
Author: Seigo Nonaka <nona@google.com>
Date: Mon Apr 27 15:15:52 2020
Add SoftwareKeyboardController
SoftwareKeyboardController is delivered to developer when
new text input session has established via onTextInputStarted callback.
Bug: 151860051
Bug: 150194952
Test: Manually done
Test: TreeHugger
Relnote: "Now it is possible to hide/show software keyboard by using
SoftwareKeyboardController which is delivered by onTextInputStarted
callback"
Change-Id: I8dc44f64d4f457339364b9624c0b3e946cdf01b3
M ui/ui-foundation/api/0.1.0-dev11.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev11.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TextLayoutDirectionModifierTest.kt
M ui/ui-text-core/api/0.1.0-dev11.txt
M ui/ui-text-core/api/current.txt
M ui/ui-text-core/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text-core/api/public_plus_experimental_current.txt
M ui/ui-text-core/api/restricted_0.1.0-dev11.txt
M ui/ui-text-core/api/restricted_current.txt
A ui/ui-text-core/src/main/java/androidx/ui/text/SoftwareKeyboardController.kt
M ui/ui-text/api/0.1.0-dev11.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev11.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt
Description
all required information.
Android Studio Build:
Version of Gradle Plugin: 4.1.0-alpha03
Version of Gradle: 6.2.1
Version of Java: 1.8
OS: Android 9
Jetpack compose and libs version: 0.1.0-dev07
After IME button click, keyboard doesn't hide.
To hide keyboard we can use extension:
fun Context.hideKeyboard() {
val imm = getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
imm.hideSoftInputFromWindow((this as Activity).currentFocus?.windowToken, 0)
}
And in our TextField:
@Composable
fun test(){
val context = ContextAmbient.current
...
TextField(
...
onImeActionPerformed = {
if (it == ImeAction.Search) {
context.hideKeyboard()
}
}
)
}
But I don`t think, that is a good to use this way. It looks like bug.