TextField doesn't hide keyboard after IME button click [151860051]

Fixed

Bug

Status Update

No update yet.

Description

dj...@gmail.com

created issue #1

Mar 19, 2020 11:09AM

IMPORTANT: Please read

https://developer.android.com/studio/report-bugs.html carefully and supply
all required information.

Android Studio Build:
Version of Gradle Plugin: 4.1.0-alpha03
Version of Gradle: 6.2.1
Version of Java: 1.8
OS: Android 9
Jetpack compose and libs version: 0.1.0-dev07

After IME button click, keyboard doesn't hide.

To hide keyboard we can use extension:

fun Context.hideKeyboard() {
val imm = getSystemService(Context.INPUT_METHOD_SERVICE) as InputMethodManager
imm.hideSoftInputFromWindow((this as Activity).currentFocus?.windowToken, 0)
}

And in our TextField:

@Composable
fun test(){
val context = ContextAmbient.current
...
TextField(
...
onImeActionPerformed = {
if (it == ImeAction.Search) {
context.hideKeyboard()
}
}
)
}

But I don`t think, that is a good to use this way. It looks like bug.

Comments

so...@google.com <so...@google.com> #2Mar 19, 2020 12:01PM

Assigned to no...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

no...@google.com <no...@google.com> #3Mar 19, 2020 06:20PM

Reassigned to an...@google.com.

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

dj...@gmail.com <dj...@gmail.com> #4Mar 19, 2020 07:58PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

si...@google.com <si...@google.com> Mar 30, 2020 03:58PM

Reassigned to no...@google.com.

no...@google.com <no...@google.com> #5Apr 3, 2020 08:46PM

Reassigned to an...@google.com.

Bulk releasing. Feel free to take if you have bandwidth.

si...@google.com <si...@google.com> Apr 17, 2020 07:09PM

Reassigned to no...@google.com.

no...@google.com <no...@google.com> #6Apr 23, 2020 10:02PM

On the second thought, now I think returning Boolean is a good idea here since that enforces developers to process the text synchronously, e.g. validation.

It is good to pass controller for hiding keyboard in some way.

ap...@google.com <ap...@google.com> #7Apr 28, 2020 07:15PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 0f2b8d58ca07aa8b1bf0c01f4af822cbae3b26d6
Author: Seigo Nonaka <nona@google.com>
Date: Mon Apr 27 15:15:52 2020

Add SoftwareKeyboardController

SoftwareKeyboardController is delivered to developer when
new text input session has established via onTextInputStarted callback.

Bug: 151860051
Bug: 150194952
Test: Manually done
Test: TreeHugger
Relnote: "Now it is possible to hide/show software keyboard by using
SoftwareKeyboardController which is delivered by onTextInputStarted
callback"

Change-Id: I8dc44f64d4f457339364b9624c0b3e946cdf01b3

M ui/ui-foundation/api/0.1.0-dev11.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev11.txt
M ui/ui-foundation/api/restricted_current.txt
A ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/SoftwareKeyboardTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/TextField.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/TextLayoutDirectionModifierTest.kt
M ui/ui-text-core/api/0.1.0-dev11.txt
M ui/ui-text-core/api/current.txt
M ui/ui-text-core/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text-core/api/public_plus_experimental_current.txt
M ui/ui-text-core/api/restricted_0.1.0-dev11.txt
M ui/ui-text-core/api/restricted_current.txt
A ui/ui-text-core/src/main/java/androidx/ui/text/SoftwareKeyboardController.kt
M ui/ui-text/api/0.1.0-dev11.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev11.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/integration-tests/ui-text-compose-demos/src/main/java/androidx/ui/text/demos/ComposeInputField.kt
M ui/ui-text/src/main/java/androidx/ui/text/CoreTextField.kt

https://android-review.googlesource.com/1296996

no...@google.com <no...@google.com> Apr 28, 2020 07:16PM

Marked as fixed.