Provide APIs for reacting to visual / interaction state [152525426]

Fixed

Feature Request

Status Update

No update yet.

Description

lp...@google.com

created issue #1

Mar 26, 2020 07:01PM

Elements typically have different visual appearance / behavior when they are:

Pressed
Hovered
Focused

etc

We should provide a consistent API story around managing these states, and make it easy to combine foundational interactions such as draggable, to wire up these states within a component.

Comments

ap...@google.com <ap...@google.com> #2Apr 22, 2020 12:48PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

ap...@google.com <ap...@google.com> #3Apr 23, 2020 07:00PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ap...@google.com <ap...@google.com> #4Aug 21, 2020 10:55AM

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

ap...@google.com <ap...@google.com> #5Nov 6, 2020 12:18PM

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ki...@google.com <ki...@google.com> #6Nov 6, 2020 05:27PM

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

ma...@google.com <ma...@google.com> #7Nov 6, 2020 05:40PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

ap...@google.com <ap...@google.com> #8Feb 9, 2021 10:17PM

Yes, this fix is planned to be included in a future 1.7.x release.

ap...@google.com <ap...@google.com> #9Feb 11, 2021 02:34AM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

an...@google.com <an...@google.com> #10Oct 6, 2021 06:03PM

Currently DefaultFloatingActionButton does not have a param for focusedElevation (it has default and hovered), so that will need to be added also

cl...@google.com <cl...@google.com> #11Oct 12, 2021 01:50PM

Confirmed with Louis this is targetting M2

ap...@google.com <ap...@google.com> #12Oct 12, 2021 04:38PM

Project: platform/frameworks/support
Branch: androidx-main

commit e897e07adb935e854493484004e822454d164e49
Author: Igor Demin <igor.demin@jetbrains.com>
Date: Wed Aug 25 20:53:19 2021

Implement HoverInteraction and Modifier.hoverable

Modifier.hoverable triggers HoverInteraction.Enter when pointer enters the component, and HoverInteraction.Exit - when pointer exits the component or when component is disposed.

```
@Composable
fun Sample1() {
val interactionSource = remember { MutableInteractionSource() }
val isHovered by interactionSource.collectIsHoveredAsState()

Box(
Modifier
.size(128.dp)
.background(if (isHovered) Color.Red else Color.Green)
.hoverable(interactionSource = interactionSource)
)
}
```

Change-Id: Iafb99afb3049206fe72a37c0f5b905fda0acba00
Bug: 152525426
Bug: 172253090
Test: ./gradlew buildOnServer
Relnote: Added Modifier.hoverable for enter/exit events of mouse/stylus/etc. See HoverableSample

M compose/foundation/foundation/api/public_plus_experimental_current.txt
M compose/foundation/foundation/api/restricted_current.txt
A compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/HoverableTest.kt
M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Scrollbar.desktop.kt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/HoverableSample.kt
M compose/foundation/foundation/build.gradle
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/HoverInteraction.kt
A compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Hoverable.kt

https://android-review.googlesource.com/1809041

ap...@google.com <ap...@google.com> #13Oct 13, 2021 12:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 60db6837fc61c0560112a659fb33d24e6d3b1d16
Author: Louis Pullen-Freilich <lpf@google.com>
Date: Tue Oct 12 18:28:42 2021

Clickable and focusable can now be focused in non-touch modes

Also adds focus state support in ripple and Material components.

Bug:

b/202856230

Fixes:

b/152525426

Fixes:

b/163725615

Test: Screenshot tests / modifier tests
Relnote: "Modifier.clickable and Modifier.toggleable can now be focused by default when using a keyboard. Ripple has been updated to support focus state, so components such as Button will now appear focused when necessary."
Change-Id: I2161d9c5e4ef4d039fb8f90cb43a94f0f15c0795

M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwitchScreenshotTest.kt
M compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/RadioButtonScreenshotTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/CheckboxScreenshotTest.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialRippleThemeTest.kt
M compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/PrintToStringTest.kt
M compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SelectableTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/FloatingActionButtonScreenshotTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt

https://android-review.googlesource.com/1853341

Issue 152525426

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Apr 22, 2020 12:48PM

ap...@google.com <ap...@google.com> #3Apr 23, 2020 07:00PM

ap...@google.com <ap...@google.com> #4Aug 21, 2020 10:55AM

ap...@google.com <ap...@google.com> #5Nov 6, 2020 12:18PM

ki...@google.com <ki...@google.com> #6Nov 6, 2020 05:27PM

ma...@google.com <ma...@google.com> #7Nov 6, 2020 05:40PM

ap...@google.com <ap...@google.com> #8Feb 9, 2021 10:17PM

ap...@google.com <ap...@google.com> #9Feb 11, 2021 02:34AM

an...@google.com <an...@google.com> #10Oct 6, 2021 06:03PM

cl...@google.com <cl...@google.com> #11Oct 12, 2021 01:50PM

ap...@google.com <ap...@google.com> #12Oct 12, 2021 04:38PM

ap...@google.com <ap...@google.com> #13Oct 13, 2021 12:24PM

Add comment

Issue metadata