IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date:   Fri Jul 10 16:23:09 2020

    Semantics no-op cleanups
   
    Partly in response to lmr's broad code review, I did a pass of
    superficial API/implementation cleanup.  The main changes are:
   
    - I changed each Boolean SemanticsProperty where false is equivalent to
      not being present to take "Unit" instead.  This is conceptually
      clearer: it avoids questions like "can I cancel out a semantics from a
      merged child by setting it to false?"  Because "property = Unit" looks
      weird, I also changed the style of these to "property()".
   
    - I moved the Semantics id generator closer to where it's used, in
      SemanticsModifierCore.  I made it internal and an AtomicInt.
      (Note that integer ids are heavily used in the Android
      AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
   
    - I deleted dead code.  Some examples include SemanticsHintOverrides,
      a public API not connected to anything, and SemanticsPropertyKey
      merge() open method which is never called.  (In both cases I have
      a different plan in mind for accessibility.)
   
    Fixes: 145951226
    Fixes: 145955412
    Test: existing tests
    Relnote: "Single-value semantics properties now use a calling style.
    For example, 'semantics { hidden = true }' is now written as:
    'semantics { hidden() }'."
   
    Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M       ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M       ui/ui-core/api/0.1.0-dev15.txt
M       ui/ui-core/api/current.txt
M       ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-core/api/public_plus_experimental_current.txt
M       ui/ui-core/api/restricted_0.1.0-dev15.txt
M       ui/ui-core/api/restricted_current.txt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M       ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M       ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M       ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M       ui/ui-foundation/api/0.1.0-dev15.txt
M       ui/ui-foundation/api/current.txt
M       ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-foundation/api/public_plus_experimental_current.txt
M       ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M       ui/ui-foundation/api/restricted_current.txt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M       ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M       ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M       ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M       ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M       ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M       ui/ui-text/api/0.1.0-dev15.txt
M       ui/ui-text/api/current.txt
M       ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M       ui/ui-text/api/public_plus_experimental_current.txt
M       ui/ui-text/api/restricted_0.1.0-dev15.txt
M       ui/ui-text/api/restricted_current.txt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M       ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8c7bd0ed6ebbfc6f21dcf133de4aff9d54be53e2
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Thu Apr 23 19:17:38 2020

    Marks InteractionState as @Stable, and fixes disposition
   
    Bug: b/152525426
    Test: n/a
    Change-Id: I61d122dce3e4004702a6284e8a65e7dfb8b2a625

M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/Interaction.kt
M       ui/ui-foundation/src/main/java/androidx/ui/foundation/InteractionState.kt

https://android-review.googlesource.com/1294087

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 794b8b605fb07b94a5e3e25cc4273a32548cfe22
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Fri Aug 21 00:23:42 2020

    Adds a sample and doc clarification for ordering in InteractionState
   
    Often in design systems (such as Material) the most recent Interaction should be the one represented by the system, but unfortunately `Set` does not have a guarantee of ordering. LinkedHashSet does, but is also mutable, which is not a contract we want for InteractionState, so instead we document this behavior and guarantee that ordering is maintained.
   
    Also adds InteractionStateTest to verify this behavior.
   
    Bug: b/161522042
    Bug: b/146345816
    Bug: b/152525426
    Test: InteractionStateTest
    Change-Id: Iac4b4c7f733788785454fc29bfe56ca2c479b294

M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/InteractionState.kt
A       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/InteractionStateTest.kt

https://android-review.googlesource.com/1406607

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c0fd11cab1b083d043dfd54c8431c4068aeef09a
Author: Matvei Malkov <malkov@google.com>
Date:   Wed Nov 04 17:35:35 2020

    Add Modifier.focusable
   
    This CL adds Modifier.focusable, which is intended to be a primary way to add focusability to the app (without clicks or with custom clicks), since it contains proper a11y and InteractionState support
   
    Change-Id: I41eb9d67669e19f8a7c20804c836a8c6dc0b5526
    RelNote: "Modifier.focusable has need added in foundation. Use this to add focusable behavior to a component, with correct semantics and accessibility."
    Bug: 152525426
    Bug: 162865824
    Bug: 163423216
    Test: added

M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ScrollableSamples.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/ZoomableSample.kt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
M       compose/ui/ui-test/api/current.txt
M       compose/ui/ui-test/api/public_plus_experimental_current.txt
M       compose/ui/ui-test/api/restricted_current.txt
M       compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Assertions.kt
M       compose/ui/ui-test/src/commonMain/kotlin/androidx/compose/ui/test/Filters.kt

https://android-review.googlesource.com/1487281

Project: platform/frameworks/support
Branch: androidx-main

commit 4ed6a9c01328ed0c177f3661b58f1b3fc29faec3
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Fri Feb 05 14:40:02 2021

    Simplifies Indication APIs
   
    Previously IndicationInstance was responsible for both writing state / launching animations and then reading state to draw indication. Typically we want to model this as a one-way pipeline, so IndicationInstance has now been simplified to be only responsible for drawing indication.
   
    Indication#createInstance() has been changed to rememberUpdatedInstance(InteractionState) to convey these responsibilities more clearly - Indication is responsible for observing InteractionState and creating an IndicationInstance which can draw visual effects for the current state.
   
    This CL leaves the current Ripple implementation as is; it will be refactored in a future CL.
   
    Bug: b/152525426
    Test: updateApi
    Test: existing tests
    Relnote: "Changed Indication#createIndication() to Indication#rememberUpdatedIndication(InteractionState) and removes InteractionState parameter from IndicationInstance#drawIndication(). IndicationInstance should only be responsible for drawing visual effects, and not launching animations / writing state in response to InteractionState changes. These animations and state writes should happen within `rememberUpdatedIndication()` instead. The `indication` parameter in `Modifier.indication` was also changed to be a required parameter."
    Change-Id: Ic1764c0417b25cd0a0dbb96ed3e1b0974618c4ca

M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/IndicationTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt

https://android-review.googlesource.com/1576438

Project: platform/frameworks/support
Branch: androidx-main

commit 2ae4491c96160cde4b70863202542499c68da4b7
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Sat Feb 06 21:48:44 2021

    InteractionState -> [Mutable]InteractionSource rework
   
    This CL replaces InteractionState with [Mutable]InteractionSource - interfaces responsible for emitting / observing Interaction events. InteractionSource exposes interactions: Flow<Interaction>, which allows consumers to observe the ordered stream of Interactions and change how components appear accordingly.
   
    This resolves a few issues with the existing InteractionState implementation:
   
    - No handling for multiple sources of the same Interaction
    For example, a compound component with two `clickable`s - if one `clickable` is pressed, then the other, then the first `clickable` is released, this would appear as though the entire InteractionState was not pressed.
   
    - Lossy compression of events into state
    InteractionState turns a stream events into a snapshot state at a given point in time. Complex components / indications such as Ripple care about the ordering of events, and trying to reconstruct ordering from a snapshot state is a bit messy and can lose information.
   
    - Batched state writes
    State<> is not a great fit for representing events as the name suggests - one of the reasons for this is that state writes are batched, so multiple changes (such as multiple fast presses) will be batched into one write. This means that we might skip showing ripples for presses if events happen too closely together.
   
    - Lack of detailed information for events
    For simple components, just knowing if the component is pressed or not can be enough to change how it appears, but for complicated components it can be important to know if a press was stopped / cancelled - this sort of information did not exist in InteractionState. Additionally metadata such as press position can be important, but there was no scalable way to support this. Now Interactions can just be unique instances with metadata, so Pressed() can contain a press position just as a property for consumers that need to know this information.
   
    As well as the `interactions` Flow, simple extension functions on InteractionSource (collectIsDraggedAsState, collectIsFocusedAsState, collectIsPressedAsState) have been added for cases when components only care about the binary state of a particular interaction, and not the entire stream of events.
   
    MutableInteractionSource exposes `emit()` and `tryEmit()` methods that allow emitting Interactions to the `interactions` Flow.
   
    This CL also changes the existing Interactions to be classes, and adds further classes representing stop / cancel events for the initial events.
   
    Bug: b/152525426
    Fixes: b/171913923
    Fixes: b/171710801
    Fixes: b/174852378
    Test: InteractionSourceTest
    Test: updateApi
    Relnote: "InteractionState has been replaced with [Mutable]InteractionSource - interfaces responsible for emitting / collecting Interaction events. Instead of passing `interactionState = remember { InteractionState() }` to components such as Button and Modifier.clickable(), use `interactionSource = remember { MutableInteractionSource() }`. Instead of: `Interaction.Pressed in interactionState` you should instead use the extension functions on InteractionSource, such as InteractionSource.collectIsPressedAsState(). For complex use cases you can use InteractionSource.interactions to observe the stream of Interactions. See the InteractionSource documentation and samples for more information."
    Change-Id: I85965d0dba39d1740c097915d1d1a367eea2a78c

M       compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/MultiDimensionalAnimationDemo.kt
M       compose/animation/animation/integration-tests/animation-demos/src/main/java/androidx/compose/animation/demos/SingleValueAnimationDemo.kt
M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/FoundationDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/ListDemos.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/text/ComposeVariousInputField.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/FocusableSample.kt
M       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/IndicationSamples.kt
A       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionSourceSample.kt
D       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/InteractionStateSample.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/DraggableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/FocusableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/IndicationTest.kt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/InteractionSourceTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ScrollableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SelectableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/text/TextFieldInteractionsTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldScrollTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/textfield/TextFieldTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
D       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Interaction.kt
D       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/InteractionState.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Scroll.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Draggable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/gestures/Scrollable.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/DragInteraction.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/FocusInteraction.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/Interaction.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/InteractionSource.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/PressInteraction.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyList.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/lazy/LazyListState.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Selectable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/BasicTextField.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/CoreTextField.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldGestureModifiers.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldPressGestureFilter.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/TextFieldScroll.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionContainer.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/selection/SelectionManager.kt
M       compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Scrollbar.desktop.kt
D       compose/foundation/foundation/src/test/kotlin/androidx/compose/foundation/InteractionStateTest.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleAnimation.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M       compose/material/material/api/current.txt
M       compose/material/material/api/public_plus_experimental_current.txt
M       compose/material/material/api/restricted_current.txt
M       compose/material/material/integration-tests/material-studies/src/main/java/androidx/compose/material/studies/rally/TopAppBar.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/BottomNavigationScreenshotTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialRippleThemeTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwipeableTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/TabScreenshotTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/textfield/TextFieldTest.kt
M       compose/material/material/src/androidMain/kotlin/androidx/compose/material/AndroidMenu.android.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/BottomNavigation.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Checkbox.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/IconButton.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Menu.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/OutlinedTextField.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/RadioButton.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Slider.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Swipeable.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Switch.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Tab.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextField.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldDefaults.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/TextFieldImpl.kt
M       compose/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
M       compose/ui/ui/integration-tests/ui-demos/src/main/java/androidx/compose/ui/demos/gestures/ScrollGestureFilterDemo.kt

https://android-review.googlesource.com/1579423

Project: platform/frameworks/support
Branch: androidx-main

commit e897e07adb935e854493484004e822454d164e49
Author: Igor Demin <igor.demin@jetbrains.com>
Date:   Wed Aug 25 20:53:19 2021

    Implement HoverInteraction and Modifier.hoverable
   
    Modifier.hoverable triggers HoverInteraction.Enter when pointer enters the component, and HoverInteraction.Exit - when pointer exits the component or when component is disposed.
   
    ```
    @Composable
    fun Sample1() {
        val interactionSource = remember { MutableInteractionSource() }
        val isHovered by interactionSource.collectIsHoveredAsState()
   
        Box(
            Modifier
                .size(128.dp)
                .background(if (isHovered) Color.Red else Color.Green)
                .hoverable(interactionSource = interactionSource)
        )
    }
    ```
   
    Change-Id: Iafb99afb3049206fe72a37c0f5b905fda0acba00
    Bug: 152525426
    Bug: 172253090
    Test: ./gradlew buildOnServer
    Relnote: Added Modifier.hoverable for enter/exit events of mouse/stylus/etc. See HoverableSample

M       compose/foundation/foundation/api/public_plus_experimental_current.txt
M       compose/foundation/foundation/api/restricted_current.txt
A       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/HoverableTest.kt
M       compose/foundation/foundation/api/current.txt
M       compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/Scrollbar.desktop.kt
M       compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/HighLevelGesturesDemo.kt
A       compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/HoverableSample.kt
M       compose/foundation/foundation/build.gradle
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/interaction/HoverInteraction.kt
A       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Hoverable.kt

https://android-review.googlesource.com/1809041

Project: platform/frameworks/support
Branch: androidx-main

commit 60db6837fc61c0560112a659fb33d24e6d3b1d16
Author: Louis Pullen-Freilich <lpf@google.com>
Date:   Tue Oct 12 18:28:42 2021

    Clickable and focusable can now be focused in non-touch modes
   
    Also adds focus state support in ripple and Material components.
   
    Bug: b/202856230
    Fixes: b/152525426
    Fixes: b/163725615
    Test: Screenshot tests / modifier tests
    Relnote: "Modifier.clickable and Modifier.toggleable can now be focused by default when using a keyboard. Ripple has been updated to support focus state, so components such as Button will now appear focused when necessary."
    Change-Id: I2161d9c5e4ef4d039fb8f90cb43a94f0f15c0795

M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Focusable.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/Ripple.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ClickableTest.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/ToggleableTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/ButtonScreenshotTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/SwitchScreenshotTest.kt
M       compose/material/material-ripple/src/commonMain/kotlin/androidx/compose/material/ripple/RippleTheme.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Elevation.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/RadioButtonScreenshotTest.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/Button.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/CheckboxScreenshotTest.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/MaterialRippleThemeTest.kt
M       compose/ui/ui-test/src/androidAndroidTest/kotlin/androidx/compose/ui/test/PrintToStringTest.kt
M       compose/material/material/src/commonMain/kotlin/androidx/compose/material/FloatingActionButton.kt
M       compose/foundation/foundation/src/androidAndroidTest/kotlin/androidx/compose/foundation/SelectableTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Indication.kt
M       compose/material/material/src/androidAndroidTest/kotlin/androidx/compose/material/FloatingActionButtonScreenshotTest.kt
M       compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Clickable.kt

https://android-review.googlesource.com/1853341