Status Update
Comments
ra...@google.com <ra...@google.com> #2
db...@digitalfleet.com <db...@digitalfleet.com> #3
ra...@google.com <ra...@google.com> #4
Can someone clarify?
db...@digitalfleet.com <db...@digitalfleet.com> #5
AppCompatDelegate generally works at the Activity level. This is the case with other features such as NightMode as well. This is why it is intended that it does not affect the application context.
I'm re-assigning this to the team to assess the feasibility of extending the feature to alter the application context.
ra...@google.com <ra...@google.com> #6
ra...@google.com <ra...@google.com> #7
We recently added a language picker to our alarm app with ~5M downloads. We were enthused when we heard of Android 13's per-app language capabilities and back-porting.
However, in practice this is a half-baked pre-Android 13 implementation. Anyone who implements it is going to have to handle attachBaseContext()
in the Application.kt, Services, and any activity that doesn't extend AppCompatActivity.
If no changes are made, I would at least suggest adding to the attachBaseContext()
for pre-Android 13, and suggested implementation for it - please don't make 1000s of developers write this code :)
Thanks!
ra...@google.com <ra...@google.com> #8
It is common use case, to be able to get string from application context besides activity & fragment. If pre-13 unable exhibit same behavior as 13 (able to get localized string from application context), then AppCompatDelegate.setApplicationLocales doesn't solve the backward compatible issue.
Due to this limitation, we can only provide such a dynamic language feature, for Android 13 only.
Description
Version used: 2.3.4
Devices/Android versions reproduced on: Android Studio
On the latest version getting the following lint error this issue does not occur on 2.3.3. All of my periodic jobs intervals are at least 30 minutes.
lint-results-debug.xml
```
<issue
id="LintError"
severity="Error"
message="Unexpected failure during lint analysis of MyWorkManagerWrapper.java (this is a bug in lint or one of the libraries it depends on)

Message: null cannot be cast to non-null type kotlin.Long

The crash seems to involve the detector `androidx.work.lint.InvalidPeriodicWorkRequestIntervalDetector`.
You can try disabling it with something like this:
 android {
 lintOptions {
 disable "InvalidPeriodicWorkRequestInterval"
 }
 }

Stack: `TypeCastException:InvalidPeriodicWorkRequestIntervalDetector.visitConstructor(InvalidPeriodicWorkRequestIntervalDetector.kt:70)←UElementVisitor$DelegatingPsiVisitor.visitNewExpression(UElementVisitor.kt:1099)←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1063)←UCallExpression$DefaultImpls.accept(UCallExpression.kt:99)←UCallExpressionEx$DefaultImpls.accept(UCallExpression.kt:-1)←JavaConstructorUCallExpression.accept(javaUCallExpressions.kt:123)←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:47)←JavaUCompositeQualifiedExpression.accept(JavaUCompositeQualifiedExpression.kt:23)`

You can set environment variable `LINT_PRINT_STACKTRACE=true` to dump a full stacktrace to stdout."
category="Lint"
priority="10"
summary="Lint Failure"
explanation="This issue type represents a problem running lint itself. Examples include failure to find bytecode for source files (which means certain detectors could not be run), parsing errors in lint configuration files, etc.

These errors are not errors in your own code, but they are shown to make it clear that some checks were not completed.">
<location
file="FILE_PATH/MyWorkManagerWrapper.java"/>
</issue>
```
Sample Code:
```
workRequest = new PeriodicWorkRequest.Builder(CustomWorker.class, workerType.interval, workerType.timeUnit).build();
workManager.enqueueUniquePeriodicWork(workerType.uniqueName, workerType.workPolicy, workRequest);
```
```
public enum PeriodicWorkerType {
PERIODIC_JOB("PERIODIC_JOB_V1", 30, TimeUnit.Minutes, ExistingPeriodicWorkPolicy.KEEP),
public final String uniqueName;
public final long interval;
public final TimeUnit timeUnit;
public final ExistingPeriodicWorkPolicy workPolicy;
PeriodicWorkerType(String uniqueName, long interval, TimeUnit timeUnit, ExistingPeriodicWorkPolicy workPolicy) {
this.uniqueName = uniqueName;
this.interval = interval;
this.timeUnit = timeUnit;
this.workPolicy = workPolicy;
}
}
```
If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).