2.3.4 Lint Error androidx.work.lint.InvalidPeriodicWorkRequestIntervalDetector [152606442]

Fixed

Bug

Status Update

No update yet.

Description

db...@digitalfleet.com

created issue #1

Mar 27, 2020 07:26PM

Component used: WorkManager
Version used: 2.3.4
Devices/Android versions reproduced on: Android Studio

On the latest version getting the following lint error this issue does not occur on 2.3.3. All of my periodic jobs intervals are at least 30 minutes.

lint-results-debug.xml
```
<issue
id="LintError"
severity="Error"
message="Unexpected failure during lint analysis of MyWorkManagerWrapper.java (this is a bug in lint or one of the libraries it depends on)

Message: null cannot be cast to non-null type kotlin.Long

The crash seems to involve the detector `androidx.work.lint.InvalidPeriodicWorkRequestIntervalDetector`.
You can try disabling it with something like this:
 android {
 lintOptions {
 disable "InvalidPeriodicWorkRequestInterval"
 }
 }

Stack: `TypeCastException:InvalidPeriodicWorkRequestIntervalDetector.visitConstructor(InvalidPeriodicWorkRequestIntervalDetector.kt:70)←UElementVisitor$DelegatingPsiVisitor.visitNewExpression(UElementVisitor.kt:1099)←UElementVisitor$DelegatingPsiVisitor.visitCallExpression(UElementVisitor.kt:1063)←UCallExpression$DefaultImpls.accept(UCallExpression.kt:99)←UCallExpressionEx$DefaultImpls.accept(UCallExpression.kt:-1)←JavaConstructorUCallExpression.accept(javaUCallExpressions.kt:123)←UQualifiedReferenceExpression$DefaultImpls.accept(UQualifiedReferenceExpression.kt:47)←JavaUCompositeQualifiedExpression.accept(JavaUCompositeQualifiedExpression.kt:23)`

You can set environment variable `LINT_PRINT_STACKTRACE=true` to dump a full stacktrace to stdout."
category="Lint"
priority="10"
summary="Lint Failure"
explanation="This issue type represents a problem running lint itself. Examples include failure to find bytecode for source files (which means certain detectors could not be run), parsing errors in lint configuration files, etc.

These errors are not errors in your own code, but they are shown to make it clear that some checks were not completed.">
<location
file="FILE_PATH/MyWorkManagerWrapper.java"/>
</issue>
```

Sample Code:
```
workRequest = new PeriodicWorkRequest.Builder(CustomWorker.class, workerType.interval, workerType.timeUnit).build();

workManager.enqueueUniquePeriodicWork(workerType.uniqueName, workerType.workPolicy, workRequest);
```
```
public enum PeriodicWorkerType {
PERIODIC_JOB("PERIODIC_JOB_V1", 30, TimeUnit.Minutes, ExistingPeriodicWorkPolicy.KEEP),

public final String uniqueName;
public final long interval;
public final TimeUnit timeUnit;
public final ExistingPeriodicWorkPolicy workPolicy;

PeriodicWorkerType(String uniqueName, long interval, TimeUnit timeUnit, ExistingPeriodicWorkPolicy workPolicy) {
this.uniqueName = uniqueName;
this.interval = interval;
this.timeUnit = timeUnit;
this.workPolicy = workPolicy;
}
}
```

If this is a bug in the library, we would appreciate if you could attach:
- Sample project to trigger the issue.
- A screenrecord or screenshots showing the issue (if UI related).

Comments

ra...@google.com <ra...@google.com> #2Mar 27, 2020 07:43PM

Status: Won't Fix (Obsolete)

This should be moved to the Android Public Tracker > Text component, but I don't have permissions so I'm redirecting to the appropriate owner.

db...@digitalfleet.com <db...@digitalfleet.com> #3Mar 27, 2020 07:47PM

So after updating to 1.4.1 and all deps too, the crash was a little different see below.

The repro for that one is easy

create a new app from AS 7.1 RC 1
update deps to (Appcompat 1.4.1/Material 1.5.0/Constraintlayout 2.1.3)
Add 2 textViews

    <TextView
        android:id="@+id/text1"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Hello World!"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toTopOf="parent" />

    <TextView
        android:id="@+id/text2"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:text="Hello World!"
        app:layout_constraintBottom_toBottomOf="parent"
        app:layout_constraintLeft_toLeftOf="parent"
        app:layout_constraintRight_toRightOf="parent"
        app:layout_constraintTop_toBottomOf="@+id/text1" />```

In onCreate:

        val t1 = findViewById<TextView>(R.id.text1)
        val t2 = findViewById<TextView>(R.id.text2)

        val charBuffer1 = CharArrayBuffer("AAA".toCharArray())
        charBuffer1.sizeCopied = 3
        val charBuffer2 = CharArrayBuffer("AAA".toCharArray())
        charBuffer2.sizeCopied = 3

        t1.setText(charBuffer1.data, 0, charBuffer1.sizeCopied)
        t2.setText(charBuffer2.data, 0, charBuffer2.sizeCopied)

Run see the texts updated then crash with the following. (Tested on P6 Pro Android 12)

Process: org.debug.myapplication, PID: 32493
    java.lang.NullPointerException: src == null
        at java.lang.System.arraycopy(Native Method)
        at android.widget.TextView$CharWrapper.getChars(TextView.java:13588)
        at android.text.TextUtils.getChars(TextUtils.java:155)
        at android.text.BoringLayout.hasAnyInterestingChars(BoringLayout.java:314)
        at android.text.BoringLayout.isBoring(BoringLayout.java:340)
        at android.widget.TextView.onMeasure(TextView.java:9413)
        at androidx.appcompat.widget.AppCompatTextView.onMeasure(AppCompatTextView.java:607)
        at android.view.View.measure(View.java:25774)
        at androidx.constraintlayout.widget.ConstraintLayout$Measurer.measure(ConstraintLayout.java:811)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.measure(BasicMeasure.java:466)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.measureChildren(BasicMeasure.java:134)
        at androidx.constraintlayout.core.widgets.analyzer.BasicMeasure.solverMeasure(BasicMeasure.java:278)
        at androidx.constraintlayout.core.widgets.ConstraintWidgetContainer.measure(ConstraintWidgetContainer.java:120)
        at androidx.constraintlayout.widget.ConstraintLayout.resolveSystem(ConstraintLayout.java:1594)
        at androidx.constraintlayout.widget.ConstraintLayout.onMeasure(ConstraintLayout.java:1708)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at androidx.appcompat.widget.ContentFrameLayout.onMeasure(ContentFrameLayout.java:145)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at androidx.appcompat.widget.ActionBarOverlayLayout.onMeasure(ActionBarOverlayLayout.java:496)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1552)
        at android.widget.LinearLayout.measureVertical(LinearLayout.java:842)
        at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6980)
        at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
        at com.android.internal.policy.DecorView.onMeasure(DecorView.java:761)
        at android.view.View.measure(View.java:25774)
        at android.view.ViewRootImpl.performMeasure(ViewRootImpl.java:3628)
        at android.view.ViewRootImpl.measureHierarchy(ViewRootImpl.java:2424)
        at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:2694)
        at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2143)
        at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:8665)
        at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1037)
        at android.view.Choreographer.doCallbacks(Choreographer.java:845)
        at android.view.Choreographer.doFrame(Choreographer.java:780)
        at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1022)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:201)
        at android.os.Looper.loop(Looper.java:288)
        at android.app.ActivityThread.main(ActivityThread.java:7839)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003)

ra...@google.com <ra...@google.com> #4Mar 27, 2020 07:56PM

Assigned to ra...@google.com.

since it is possibly related to emojicompat reassigned

db...@digitalfleet.com <db...@digitalfleet.com> #5Mar 27, 2020 07:58PM

Thanks for the report.

What version of Android are you testing this on?

Message last modified on Mar 27, 2020 08:06PM

ra...@google.com <ra...@google.com> #6Mar 27, 2020 08:59PM

Android 12 P6 pro P3a and emulator A 11.

Can test on others the last repro is easy to test.

Message last modified on Mar 27, 2020 09:02PM

ra...@google.com <ra...@google.com> #7Mar 30, 2020 06:36PM

Marked as fixed.

Thanks! That's helpful to know it's reproing on both 11 and 12 - no need to test on others. We'll have to explore a bit.

ra...@google.com <ra...@google.com> #8Mar 30, 2020 06:37PM

Any feedback on this? Appcompat 1.6 is around the corner with Android T. Migrating away from CharArrayBuffer is a ton of work to try to keep the huge performance gain it provide for my use case.