use applicationId instead of hardcoded app:graphPackage [152696768]

Fixed

Feature Request

Status Update

No update yet.

Description

b9...@gmail.com

created issue #1

Mar 30, 2020 05:48AM

Component used: Dynamic Navigator library

Just like the doc says:
app:graphPackage: the package name of the dynamic feature module. The package name is usually in the form of applicationId.moduleName. You can verify the package name by opening a dynamic feature APK in Android Studio's APK Analyzer and then opening the resources.arsc file, which is located in the root folder of your APK.

applicationId will changed between build variants in Gradle (dev/rc/staging), thus we can't hardcode applicationId.moduleName in xml without using placeholder, further more I think graphPackage attr could be replaced by "${applicatonId}.$moduleName", so that we don't need write this manually.

Comments

il...@google.com <il...@google.com> #2Mar 30, 2020 08:23PM

Assigned to be...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

st...@zeppelin.co.jp <st...@zeppelin.co.jp> #3Mar 31, 2020 03:35AM

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

b9...@gmail.com <b9...@gmail.com> #4Mar 31, 2020 04:22AM

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

wk...@google.com <wk...@google.com> #5Mar 31, 2020 08:55AM

Accepted by wk...@google.com.

I'll take it, it should be possible to do both

ap...@google.com <ap...@google.com> #6Apr 2, 2020 09:37AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5a90b4603457fd3218e2710eb6405736b5f60a48
Author: Wojtek Kaliciński <wkal@google.com>
Date: Tue Mar 31 12:42:26 2020

Placeholder and default support in app:graphPackage

It's possible to specify ${applicationId} in the graphPackage string.

If graphPackage is omitted a default will be provided at runtime:
context.packageName + "." + moduleName

Relnote: "For dynamic graph includes you no longer need to specify
`app:graphPackage` and a default one will be used by adding `moduleName`
suffix to the `applicationId` after a dot. If you do need to customize
your `graphPackage`, an `${applicationId}` placeholder is now supported."

Test: DynamicIncludeGraphNavigatorTest
Fixes:

b/152696768

Change-Id: Ida52ce2100fbc3275bf230c5dad6362b4e36cc9f

M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/test/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigatorTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.java

https://android-review.googlesource.com/1272905

il...@google.com <il...@google.com> #7Apr 2, 2020 05:28PM

We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05.

b9...@gmail.com <b9...@gmail.com> #8Apr 2, 2020 05:33PM

So quick! Thanks!👍