Status Update
No update yet.
Comments
il...@google.com
Sounds like there are two viable feature requests here:
-
Provide support for
${applicationId}directive in theapp:graphPackagefield, which would be replaced at runtime with the package name (this would mirror the same support we have for<deeplink>elements). -
Default the
app:graphPackagetoapplicationId.moduleName, meaning you could leave out theapp:graphPackagein most cases - you'd only use it if you want to customize the package name.
st...@zeppelin.co.jp
b9...@gmail.com
#3 I think request(2) is enough, as final generated applicationId includes suffix, same behavior as you place ${applicationId} in
wk...@google.com
I'll take it, it should be possible to do both
ap...@google.com
Branch: androidx-master-dev
commit 5a90b4603457fd3218e2710eb6405736b5f60a48
Author: Wojtek Kaliciński <wkal@google.com>
Date: Tue Mar 31 12:42:26 2020
Placeholder and default support in app:graphPackage
It's possible to specify ${applicationId} in the graphPackage string.
If graphPackage is omitted a default will be provided at runtime:
context.packageName + "." + moduleName
Relnote: "For dynamic graph includes you no longer need to specify
`app:graphPackage` and a default one will be used by adding `moduleName`
suffix to the `applicationId` after a dot. If you do need to customize
your `graphPackage`, an `${applicationId}` placeholder is now supported."
Test: DynamicIncludeGraphNavigatorTest
Fixes:
Change-Id: Ida52ce2100fbc3275bf230c5dad6362b4e36cc9f
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/test/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigatorTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.java
il...@google.com
We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05.
b9...@gmail.com
So quick! Thanks!👍
Description
Just like the doc says:
app:graphPackage: the package name of the dynamic feature module. The package name is usually in the form of applicationId.moduleName. You can verify the package name by opening a dynamic feature APK in Android Studio's APK Analyzer and then opening the resources.arsc file, which is located in the root folder of your APK.
applicationId will changed between build variants in Gradle (dev/rc/staging), thus we can't hardcode applicationId.moduleName in xml without using placeholder, further more I think graphPackage attr could be replaced by "${applicatonId}.$moduleName", so that we don't need write this manually.