Fixed
Status Update
No update yet.
Comments
il...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
st...@zeppelin.co.jp
b9...@gmail.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
wk...@google.com
I'll take it, it should be possible to do both
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5a90b4603457fd3218e2710eb6405736b5f60a48
Author: Wojtek Kaliciński <wkal@google.com>
Date: Tue Mar 31 12:42:26 2020
Placeholder and default support in app:graphPackage
It's possible to specify ${applicationId} in the graphPackage string.
If graphPackage is omitted a default will be provided at runtime:
context.packageName + "." + moduleName
Relnote: "For dynamic graph includes you no longer need to specify
`app:graphPackage` and a default one will be used by adding `moduleName`
suffix to the `applicationId` after a dot. If you do need to customize
your `graphPackage`, an `${applicationId}` placeholder is now supported."
Test: DynamicIncludeGraphNavigatorTest
Fixes:
Change-Id: Ida52ce2100fbc3275bf230c5dad6362b4e36cc9f
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/test/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigatorTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.java
https://android-review.googlesource.com/1272905
Branch: androidx-master-dev
commit 5a90b4603457fd3218e2710eb6405736b5f60a48
Author: Wojtek Kaliciński <wkal@google.com>
Date: Tue Mar 31 12:42:26 2020
Placeholder and default support in app:graphPackage
It's possible to specify ${applicationId} in the graphPackage string.
If graphPackage is omitted a default will be provided at runtime:
context.packageName + "." + moduleName
Relnote: "For dynamic graph includes you no longer need to specify
`app:graphPackage` and a default one will be used by adding `moduleName`
suffix to the `applicationId` after a dot. If you do need to customize
your `graphPackage`, an `${applicationId}` placeholder is now supported."
Test: DynamicIncludeGraphNavigatorTest
Fixes:
Change-Id: Ida52ce2100fbc3275bf230c5dad6362b4e36cc9f
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigator.kt
M navigation/navigation-dynamic-features-runtime/src/test/java/androidx/navigation/dynamicfeatures/DynamicIncludeGraphNavigatorTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavInflater.java
il...@google.com
We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05.
b9...@gmail.com
So quick! Thanks!👍
Description
Just like the doc says:
app:graphPackage: the package name of the dynamic feature module. The package name is usually in the form of applicationId.moduleName. You can verify the package name by opening a dynamic feature APK in Android Studio's APK Analyzer and then opening the resources.arsc file, which is located in the root folder of your APK.
applicationId will changed between build variants in Gradle (dev/rc/staging), thus we can't hardcode applicationId.moduleName in xml without using placeholder, further more I think graphPackage attr could be replaced by "${applicatonId}.$moduleName", so that we don't need write this manually.