Fixed
Status Update
Comments
mo...@google.com <mo...@google.com> #2
+1
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 1cc5db9930aed67cff08f87ddc821e9be82174cb
Author: George Mount <mount@google.com>
Date: Tue Mar 31 10:12:56 2020
Add positionInParent and boundsInParent
Fixes: 152735784
Relnote: Added positionInParent and boundsInParent for LayoutCoordinates.
Test: New tests
Change-Id: Icacdd0909bc434cd5fd935c46e0a07b965c6a38d
M ui/ui-core/api/0.1.0-dev09.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev09.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/LayoutCoordinates.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OnPositionedTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/OnPositionedTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/IconButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-test/api/0.1.0-dev09.txt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_0.1.0-dev09.txt
M ui/ui-test/api/restricted_current.txt
D ui/ui-test/src/main/java/androidx/ui/test/LayoutCoordinatesHelper.kt
https://android-review.googlesource.com/1275034
Branch: androidx-master-dev
commit 1cc5db9930aed67cff08f87ddc821e9be82174cb
Author: George Mount <mount@google.com>
Date: Tue Mar 31 10:12:56 2020
Add positionInParent and boundsInParent
Fixes: 152735784
Relnote: Added positionInParent and boundsInParent for LayoutCoordinates.
Test: New tests
Change-Id: Icacdd0909bc434cd5fd935c46e0a07b965c6a38d
M ui/ui-core/api/0.1.0-dev09.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev09.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/LayoutCoordinates.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OnPositionedTest.kt
M ui/ui-layout/src/androidTest/java/androidx/ui/layout/test/OnPositionedTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/IconButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-test/api/0.1.0-dev09.txt
M ui/ui-test/api/current.txt
M ui/ui-test/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-test/api/public_plus_experimental_current.txt
M ui/ui-test/api/restricted_0.1.0-dev09.txt
M ui/ui-test/api/restricted_current.txt
D ui/ui-test/src/main/java/androidx/ui/test/LayoutCoordinatesHelper.kt
Description
inline val LayoutCoordinates.positionInParent: PxPosition
get() = parentCoordinates?.childToLocal(this, PxPosition.Origin) ?: PxPosition.Origin
inline val LayoutCoordinates.boundsInParent: PxBounds
get() = PxBounds(positionInParent, size.toPxSize())
We discussed it a while ago, do you think now we can add such overloads for the public api?