Deprecate ColoredRect [152753731]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Mar 30, 2020 03:07PM

With full-modifiers-mode we don't need ColoredRect anymore. There's little to no cases where you actually need Colored Rectangle in real life. People need some layout with background.

ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with ColoredRect for background.

We better deprecate it

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

Is this really a P1? This seems less priority than the perf work that I am doing but if it is a P1 I will block that and work on this.

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

Marked as fixed.

I'm happy to move it to a p2, but it seems like a pretty big correctness issue that we should take a look at in the near future. I'm also happy to help look at this myself if you can give me some pointers on what the issue may be

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

This is not simple as and will change once Jim lands the threading of the composer.

Issue 152753731

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

Add comment

Issue metadata