Deprecate ColoredRect [152753731]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Mar 30, 2020 03:07PM

With full-modifiers-mode we don't need ColoredRect anymore. There's little to no cases where you actually need Colored Rectangle in real life. People need some layout with background.

ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with ColoredRect for background.

We better deprecate it

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

Andrey,

Even with the iteration index fix we are planning there are still cases where the hash code is going to be the same as a hash code is not guaranteed to be unique. Can we replace this error message with a less scary sounding error that indicates that a key should be used to disambiguate the storage key?

This is a duplicate of b/154920561 but I am leaving it open assigned to Andrey to account for the scary message and any work he can do on his side of this.

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

Marked as fixed.

Chuck, it is probably a duplicate of

b/154920561

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

ah, I didn't notice you already answered on it. yes, I can improve the messaging. I just hope it will not be happening for such simple cases at least

Issue 152753731

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

Add comment

Issue metadata