Fixed
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 75c42d0ee50b884d71f407e909b050822afcb05d
Author: Matvei Malkov <malkov@google.com>
Date: Mon Mar 30 16:03:11 2020
Deprecate ColoredRect
With full-modifiers-mode we don't need ColoredRect anymore. There's little to no cases where you actually need Colored Rectangle in real life. People need some layout with background. ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with coloredRect for background.
This CL deprecates ColoredRecr with recommendation to use Box(Modifier.preferedSize(width, height).drawBackground(color)) instead.
All places when ColoredRect is used has been changed to Box.
RelNote: ColoredRect has been deprecated. Use Box(Modifier.preferredSize(width, height).drawBackground(color)) instead.
Bug: 152753731
Test: changed tests, should pass
Change-Id: I499fa26b66b128943500fbdf9ba490d754adf561
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M ui/integration-tests/test/src/androidTest/java/androidx/ui/integration/test/TableRecompositionTest.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/NestedScrollerTestCase.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/RectsInColumnSharedModelTestCase.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/RectsInColumnTestCase.kt
M ui/ui-animation/samples/src/main/java/androidx/ui/animation/samples/AnimatedValueSamples.kt
M ui/ui-animation/samples/src/main/java/androidx/ui/animation/samples/TransitionSamples.kt
M ui/ui-foundation/api/0.1.0-dev09.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev09.txt
M ui/ui-foundation/api/restricted_current.txt
D ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ColoredRectSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DarkThemeSample.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/TableBordersSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ColoredRectTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/ColoredRect.kt
M ui/ui-layout/samples/src/main/java/androidx/ui/layout/samples/SizeModifierSample.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/CommonUi.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/DrawerSamples.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ScaffoldSamples.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ThemeSamples.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Divider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
https://android-review.googlesource.com/1271884
Branch: androidx-master-dev
commit 75c42d0ee50b884d71f407e909b050822afcb05d
Author: Matvei Malkov <malkov@google.com>
Date: Mon Mar 30 16:03:11 2020
Deprecate ColoredRect
With full-modifiers-mode we don't need ColoredRect anymore. There's little to no cases where you actually need Colored Rectangle in real life. People need some layout with background. ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with coloredRect for background.
This CL deprecates ColoredRecr with recommendation to use Box(Modifier.preferedSize(width, height).drawBackground(color)) instead.
All places when ColoredRect is used has been changed to Box.
RelNote: ColoredRect has been deprecated. Use Box(Modifier.preferredSize(width, height).drawBackground(color)) instead.
Bug: 152753731
Test: changed tests, should pass
Change-Id: I499fa26b66b128943500fbdf9ba490d754adf561
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/realworld4/RealWorld4_Widgets.kt
M ui/integration-tests/test/src/androidTest/java/androidx/ui/integration/test/TableRecompositionTest.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/NestedScrollerTestCase.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/RectsInColumnSharedModelTestCase.kt
M ui/integration-tests/test/src/main/java/androidx/ui/integration/test/foundation/RectsInColumnTestCase.kt
M ui/ui-animation/samples/src/main/java/androidx/ui/animation/samples/AnimatedValueSamples.kt
M ui/ui-animation/samples/src/main/java/androidx/ui/animation/samples/TransitionSamples.kt
M ui/ui-foundation/api/0.1.0-dev09.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev09.txt
M ui/ui-foundation/api/restricted_current.txt
D ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ColoredRectSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DarkThemeSample.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/DeterminateProgressSamples.kt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/TableBordersSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ColoredRectTest.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/DeterminateProgressTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/ColoredRect.kt
M ui/ui-layout/samples/src/main/java/androidx/ui/layout/samples/SizeModifierSample.kt
M ui/ui-material/integration-tests/material-studies/src/main/java/androidx/ui/material/studies/rally/CommonUi.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/DrawerSamples.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ScaffoldSamples.kt
M ui/ui-material/samples/src/main/java/androidx/ui/material/samples/ThemeSamples.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/TabTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/DataTable.kt
M ui/ui-material/src/main/java/androidx/ui/material/Divider.kt
M ui/ui-material/src/main/java/androidx/ui/material/Tab.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/BitmapCapturingTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdb7e3ae509091f240313922244daefda0c24dea
Author: Matvei Malkov <malkov@google.com>
Date: Fri May 01 17:11:57 2020
Remove ColoredRect
After ColoredRect was deprecated, few releases have passed, so it's time to delete it completely
Change-Id: I983c7fe9b61d873421278caf1c46ff9461307642
Relnote: ColoredRect has been removed. User Box with drawBackground modifier instead
Bug: 152753731
Test: n/a
M ui/ui-foundation/api/0.1.0-dev11.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev11.txt
M ui/ui-foundation/api/restricted_current.txt
D ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ColoredRectTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/ColoredRect.kt
https://android-review.googlesource.com/1300075
Branch: androidx-master-dev
commit bdb7e3ae509091f240313922244daefda0c24dea
Author: Matvei Malkov <malkov@google.com>
Date: Fri May 01 17:11:57 2020
Remove ColoredRect
After ColoredRect was deprecated, few releases have passed, so it's time to delete it completely
Change-Id: I983c7fe9b61d873421278caf1c46ff9461307642
Relnote: ColoredRect has been removed. User Box with drawBackground modifier instead
Bug: 152753731
Test: n/a
M ui/ui-foundation/api/0.1.0-dev11.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev11.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev11.txt
M ui/ui-foundation/api/restricted_current.txt
D ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ColoredRectTest.kt
D ui/ui-foundation/src/main/java/androidx/ui/foundation/ColoredRect.kt
Description
ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with ColoredRect for background.
We better deprecate it