Deprecate ColoredRect [152753731]

Fixed

Feature Request

Status Update

No update yet.

Description

ma...@google.com

created issue #1

Mar 30, 2020 03:07PM

With full-modifiers-mode we don't need ColoredRect anymore. There's little to no cases where you actually need Colored Rectangle in real life. People need some layout with background.

ColoredRect was failing us in few ways, starting form accepting params that should be modifiers to sending incorrect message, so people were putting together Stack with ColoredRect for background.

We better deprecate it

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

There is a report about it in kotlinlang Slack: https://kotlinlang.slack.com/archives/C01D6HTPATV/p1706005056105739

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

Marked as fixed.

Thanks for the report!

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

The release notes documentation has been edited to clarify this change in behavior for line height.

To support non-standard text sizes, we encourage users to follow the Material design system and use a different type scale rather than changing the font size directly. Alternatively, users can overwrite the line height like so: style = LocalTextStyle.current.copy(lineHeight = TextUnit.Unspecified), or create a custom Typography entirely.

Issue 152753731

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 31, 2020 12:09PM

ma...@google.com <ma...@google.com> #3Apr 6, 2020 10:38AM

ap...@google.com <ap...@google.com> #4May 1, 2020 11:00PM

Add comment

Issue metadata