Material shapes should support RTL [152756983]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Mar 30, 2020 03:49PM

Currently when we create RoundedCornerShape or CutCornerShape we specify topLeft corner. It should be topStart instead and be auto-mirroring the corners for RTL. Usually corners are symmetrical, but for example in Owl Material study they are not

https://material.io/design/material-studies/owl.html#shape
"For right-to-left languages, the opposite corners are shaped."

Comments

ap...@google.com <ap...@google.com> #2Jan 21, 2021 11:33AM

Never got around to posting the stacktraces + repro, sorry!

Simple repro:

@Composable
fun NoAssociatedStateIssueRepro() {
    val state = rememberModalBottomSheetState(ModalBottomSheetValue.HalfExpanded)
    ModalBottomSheetLayout(
        sheetState = state,
        sheetContent = { Box(Modifier.height(56.dp) }
    ) {

    }
}

The same crash can be provoked by having an empty sheet content:

@Composable
fun EmptySheetContentIssueRepro() {
    val state = rememberModalBottomSheetState(ModalBottomSheetValue.HalfExpanded)
    ModalBottomSheetLayout(
        sheetState = state,
        sheetContent = { }
    ) {

    }
}

This will crash with

java.lang.IllegalArgumentException: The initial value must have an associated anchor.
        at androidx.compose.material.SwipeableState.ensureInit$material_debug(Swipeable.kt:139)
        at androidx.compose.material.SwipeableKt$swipeable$3.invoke(Swipeable.kt:579)
        at androidx.compose.material.SwipeableKt$swipeable$3.invoke(Swipeable.kt:571)
        at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:75)
        at androidx.compose.ui.ComposedModifierKt$materialize$result$1.invoke(ComposedModifier.kt:70)
        at androidx.compose.ui.Modifier$Element$DefaultImpls.foldIn(Modifier.kt:107)
        at androidx.compose.ui.ComposedModifier.foldIn(ComposedModifier.kt:47)
        at androidx.compose.ui.CombinedModifier.foldIn(Modifier.kt:149)
        at androidx.compose.ui.ComposedModifierKt.materialize(ComposedModifier.kt:70)
        at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke-Deg8D_g(Layout.kt:174)
        at androidx.compose.ui.layout.LayoutKt$materializerOf$1.invoke(Layout.kt:173)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:130)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$2.invoke-jYbf7pk(ModalBottomSheet.kt:399)
        at androidx.compose.material.ModalBottomSheetKt$ModalBottomSheetLayout$2.invoke(ModalBottomSheet.kt:269)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:149)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.material.ModalBottomSheetKt$BottomSheetStack$1$1$placeable$1.invoke(ModalBottomSheet.kt:344)
        at androidx.compose.material.ModalBottomSheetKt$BottomSheetStack$1$1$placeable$1.invoke(ModalBottomSheet.kt:344)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:121)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2$1.invoke(SubcomposeLayout.kt:167)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2$1.invoke(SubcomposeLayout.kt:167)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:121)
        at androidx.compose.runtime.internal.ComposableLambdaImpl.invoke(ComposableLambda.kt:46)
        at androidx.compose.runtime.ComposerKt.invokeComposable(Composer.kt:3422)
        at androidx.compose.runtime.ComposerImpl.composeContent$runtime_debug(Composer.kt:2604)
        at androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:348)
        at androidx.compose.runtime.Recomposer.composeInitial$runtime_debug(Recomposer.kt:697)
        at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_debug(Composer.kt:3028)
        at androidx.compose.runtime.ComposerImpl$CompositionContextImpl.composeInitial$runtime_debug(Composer.kt:3028)
        at androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:304)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcomposeInto(SubcomposeLayout.kt:184)
        at androidx.compose.ui.layout.SubcomposeLayoutState.access$subcomposeInto(SubcomposeLayout.kt:100)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:160)
        at androidx.compose.ui.layout.SubcomposeLayoutState$subcompose$2.invoke(SubcomposeLayout.kt:158)
        at androidx.compose.runtime.snapshots.SnapshotStateObserver.withNoObservations(SnapshotStateObserver.kt:137)
        at androidx.compose.ui.node.OwnerSnapshotObserver.withNoSnapshotReadObservation$ui_debug(OwnerSnapshotObserver.kt:49)
        at androidx.compose.ui.node.LayoutNode.withNoSnapshotReadObservation$ui_debug(LayoutNode.kt:1086)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:158)
        at androidx.compose.ui.layout.SubcomposeLayoutState.subcompose(SubcomposeLayout.kt:152)

ap...@google.com <ap...@google.com> #3Jan 26, 2021 08:15PM

Marked as fixed.

Thanks Jossi, we'll take a look into it :)

Issue 152756983

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Jan 21, 2021 11:33AM

ap...@google.com <ap...@google.com> #3Jan 26, 2021 08:15PM

Add comment

Issue metadata