Explaing ScaleFit modes better [152842521]

Fixed

Feature Request

Status Update

No update yet.

Description

an...@google.com

created issue #1

Mar 31, 2020 10:52AM

What if in the comments for all the ScaleFit modes we will add a notes like "Behaves as ImageView.ScaleType. CENTER_CROP". I think if will help with learning curve and the migration to Compose UI from the Views system

Comments

nj...@google.com <nj...@google.com> #2Apr 1, 2020 05:43PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

an...@google.com <an...@google.com> #3Apr 1, 2020 06:06PM

as I and few devrel folks did we will still try to make analogs mentally. this means it would be nice to explain more of the difference between ScaleType and ScaleFit in the documentation and mention how to write the analogues for all ImageView.ScaleType. we should document somewhere how to achieve CENTER_CROP with our components, otherwise users will try to find this info on stackoverflow

ch...@google.com <ch...@google.com> #4Apr 2, 2020 09:27AM

+1. I think it's fine to say that:

ScaleType.CENTER_CROP : scaleFit = ScaleFit.FillMaxDimension, alignment = Alignment.CENTER
ScaleType.CENTER_INSIDE : scaleFit = ScaleFit.FillMinDimension, alignment = Alignment.CENTER
etc

(Even after talking about it yesterday, I had a hard time remembering and writing which scaleFit is crop, and which is inside)

ap...@google.com <ap...@google.com> #5Apr 7, 2020 09:48PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 83158eda183d97d536996830d8a22f78fc27326f
Author: Nader Jawad <njawad@google.com>
Date: Fri Apr 03 11:11:31 2020

Renamed ScaleFit API and added documentation
for improved clarity

Relnote: "Renamed ScaleFit to ContentScale
Moved ContentScale from ui-graphics to ui-core
module to live in the same module as the Alignment
API.
Renamed FillMaxDimension to Crop
Renamed FillMinDimension to Fit
Renamed Fit to Inside to better match
ImageView.ScaleType equivalents
Added documentation indicating that the combination
of Crop and Alignment.Center achieves the same result
as ImageView.ScaleType.CENTER_CROP and Fit
used with Alignment.Center achieves the same result as
ImageView.ScaleType.FIT_CENTER
Inside used with Alignment.Center achieves the same
result as ImageView.ScaleType.CENTER_INSIDE"

Bug: 152842521
Test: Updated/re-ran tests
Change-Id: I45f09c681afda9c83483b20405ec21292593b41a

M ui/ui-core/api/0.1.0-dev09.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev09.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/main/java/androidx/ui/core/ContentScale.kt
A ui/ui-core/src/main/java/androidx/ui/core/ScaleFit.kt
M ui/ui-core/src/test/java/androidx/ui/core/ContentScaleTest.kt
M ui/ui-foundation/api/0.1.0-dev09.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev09.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/samples/src/main/java/androidx/ui/foundation/samples/ImageSamples.kt
M ui/ui-foundation/src/androidTest/java/androidx/ui/foundation/ImageTest.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Image.kt
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/VectorGraphicsDemo.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/PainterModifierTest.kt
M ui/ui-framework/src/main/java/androidx/ui/core/PainterModifier.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorAsset.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-graphics/api/0.1.0-dev09.txt
M ui/ui-graphics/api/current.txt
M ui/ui-graphics/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-graphics/api/public_plus_experimental_current.txt
M ui/ui-graphics/api/restricted_0.1.0-dev09.txt
M ui/ui-graphics/api/restricted_current.txt

https://android-review.googlesource.com/1278153

an...@google.com <an...@google.com> Apr 8, 2020 09:26AM

Marked as fixed.

Issue 152842521