Fixed
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 54010b381f68649bccd160acf98fc69c83f08f72
Author: George Mount <mount@google.com>
Date: Tue Mar 31 18:03:06 2020
Change DrawModifier.drawContent() to accept Canvas.
Relnote: "Improve DrawModifier API:
* Made the receiver scope for draw() ContentDrawScope
* Removed all parameters on draw()
* DrawScope has same interface as former CanvasScope
* ContentDrawScope has drawContent() method"
Fixes: 152919067
Test: ran existing tests
Change-Id: Ibaced5feb8778510b8fe78e96f4fd3da1a6fda50
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/ComposeBenchmark.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/deeptree/DeepTree.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/siblings/SiblingManagement.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/FancyScrollingDemo.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SpringBackScrollingDemo.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SwipeToDismissDemo.kt
M ui/ui-core/api/0.1.0-dev09.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev09.txt
M ui/ui-core/api/restricted_current.txt
A ui/ui-core/src/main/java/androidx/ui/core/ContentDrawScope.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawModifier.kt
D ui/ui-core/src/main/java/androidx/ui/core/DrawReceiver.kt
M ui/ui-foundation/api/0.1.0-dev09.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev09.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Canvas.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DrawBackground.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DrawBorder.kt
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/gestures/NestedScrollingDemo.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawReorderingTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ModelReadsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ParentDataModifierTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt
M ui/ui-framework/src/main/java/androidx/ui/core/CoreText.kt
M ui/ui-framework/src/main/java/androidx/ui/core/CoreTextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/core/PainterModifier.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-framework/src/main/java/androidx/ui/node/ViewInterop.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/MaterialTextField.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
M ui/ui-platform/src/test/java/androidx/ui/core/ComponentNodeTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
https://android-review.googlesource.com/1275144
Branch: androidx-master-dev
commit 54010b381f68649bccd160acf98fc69c83f08f72
Author: George Mount <mount@google.com>
Date: Tue Mar 31 18:03:06 2020
Change DrawModifier.drawContent() to accept Canvas.
Relnote: "Improve DrawModifier API:
* Made the receiver scope for draw() ContentDrawScope
* Removed all parameters on draw()
* DrawScope has same interface as former CanvasScope
* ContentDrawScope has drawContent() method"
Fixes: 152919067
Test: ran existing tests
Change-Id: Ibaced5feb8778510b8fe78e96f4fd3da1a6fda50
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/ComposeBenchmark.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/deeptree/DeepTree.kt
M compose/compose-runtime/compose-runtime-benchmark/src/androidTest/java/androidx/compose/benchmark/siblings/SiblingManagement.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/FancyScrollingDemo.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SpringBackScrollingDemo.kt
M ui/ui-animation/integration-tests/animation-demos/src/main/java/androidx/ui/animation/demos/SwipeToDismissDemo.kt
M ui/ui-core/api/0.1.0-dev09.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev09.txt
M ui/ui-core/api/restricted_current.txt
A ui/ui-core/src/main/java/androidx/ui/core/ContentDrawScope.kt
M ui/ui-core/src/main/java/androidx/ui/core/DrawModifier.kt
D ui/ui-core/src/main/java/androidx/ui/core/DrawReceiver.kt
M ui/ui-foundation/api/0.1.0-dev09.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev09.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Canvas.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DrawBackground.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/DrawBorder.kt
M ui/ui-framework/api/0.1.0-dev09.txt
M ui/ui-framework/api/current.txt
M ui/ui-framework/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-framework/api/public_plus_experimental_current.txt
M ui/ui-framework/api/restricted_0.1.0-dev09.txt
M ui/ui-framework/api/restricted_current.txt
M ui/ui-framework/integration-tests/framework-demos/src/main/java/androidx/ui/framework/demos/gestures/NestedScrollingDemo.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/AndroidLayoutDrawTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ClipTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawReorderingTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/DrawShadowTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ModelReadsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/OpacityTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/ParentDataModifierTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/core/test/WithConstraintsTest.kt
M ui/ui-framework/src/androidTest/java/androidx/ui/graphics/vector/VectorInvalidationTestCase.kt
M ui/ui-framework/src/main/java/androidx/ui/core/CoreText.kt
M ui/ui-framework/src/main/java/androidx/ui/core/CoreTextField.kt
M ui/ui-framework/src/main/java/androidx/ui/core/Draw.kt
M ui/ui-framework/src/main/java/androidx/ui/core/PainterModifier.kt
M ui/ui-framework/src/main/java/androidx/ui/core/selection/SelectionHandles.kt
M ui/ui-framework/src/main/java/androidx/ui/graphics/vector/VectorCompose.kt
M ui/ui-framework/src/main/java/androidx/ui/node/ViewInterop.kt
M ui/ui-material/src/main/java/androidx/ui/material/Checkbox.kt
M ui/ui-material/src/main/java/androidx/ui/material/MaterialTextField.kt
M ui/ui-material/src/main/java/androidx/ui/material/ProgressIndicator.kt
M ui/ui-material/src/main/java/androidx/ui/material/RadioButton.kt
M ui/ui-material/src/main/java/androidx/ui/material/Switch.kt
M ui/ui-material/src/main/java/androidx/ui/material/ripple/Ripple.kt
M ui/ui-platform/api/0.1.0-dev09.txt
M ui/ui-platform/api/current.txt
M ui/ui-platform/api/public_plus_experimental_0.1.0-dev09.txt
M ui/ui-platform/api/public_plus_experimental_current.txt
M ui/ui-platform/api/restricted_0.1.0-dev09.txt
M ui/ui-platform/api/restricted_current.txt
M ui/ui-platform/src/main/java/androidx/ui/core/AndroidOwner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ComponentNodes.kt
M ui/ui-platform/src/main/java/androidx/ui/core/LayoutNodeWrapper.kt
M ui/ui-platform/src/main/java/androidx/ui/core/Owner.kt
M ui/ui-platform/src/main/java/androidx/ui/core/RenderNodeLayer.kt
M ui/ui-platform/src/main/java/androidx/ui/core/ViewLayer.kt
M ui/ui-platform/src/test/java/androidx/ui/core/ComponentNodeTest.kt
M ui/ui-tooling/src/androidTest/java/androidx/ui/tooling/InspectableTests.kt
Description
The DrawModifier API needs improving: