Make it a bit clearer how to use alternate constructor of Fragment [153042497]

Fixed

Bug

Status Update

No update yet.

Description

cy...@gmail.com

created issue #1

Apr 2, 2020 09:46AM

When reading `Fragment` constructors documentation, it is indicated it is possible to use a different `FragmentFactory` and that the default one will use no-arg constructor.

It would be nice to better explain that when implementing a `Fragment` with a `layoutId`, client should make sure they always call `super(int)`

`class MyFragment : Fragment(R.layout.fragment_my)` which basically indicates that `MyFragment` has a no-arg constructor (used by the default `FragmentFactory`) that will always set its `contentLayoutId` to `R.Layout.fragment_my`.

Comments

il...@google.com <il...@google.com> Apr 2, 2020 09:53PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 2, 2020 01:53AM

We also need documentation with a few examples for it.

jb...@google.com <jb...@google.com> #3May 4, 2020 03:28PM

Marked as fixed.

Any progress with the documentation?

jb...@google.com <jb...@google.com> May 4, 2020 05:11PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #4May 4, 2020 05:57PM

Changelists related to this issue will be linked once they are submitted.

jb...@google.com <jb...@google.com> #5May 4, 2020 06:20PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit dc23f5c30d0394593e16a594c1502059f7e11140
Author: Ben Weiss <benweiss@google.com>
Date: Mon Mar 09 13:08:13 2020

Kotlin DSL for navigation-dynamic-features-*

Test: check & connectedCheck of affected modules

Bug: 148969800

Change-Id: Icd0cb16fbe7035aca6638c5fb984f27b6eb1ee0c

M navigation/navigation-dynamic-features-fragment/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/AndroidManifest.xml
A navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
A navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilder.kt
M navigation/navigation-dynamic-features-runtime/api/2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/current.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_2.3.0-alpha04.txt
M navigation/navigation-dynamic-features-runtime/api/restricted_current.txt
A navigation/navigation-dynamic-features-runtime/src/androidTest/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigator.kt
A navigation/navigation-dynamic-features-runtime/src/main/java/androidx/navigation/dynamicfeatures/DynamicActivityNavigatorDestinationBuilder.kt

https://android-review.googlesource.com/1253672

Issue 153042497