Fixed
Status Update
No update yet.
Comments
il...@google.com
ap...@google.com
Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.
jb...@google.com
Great! Thanks a lot, I'll look for the live updates soon!
jb...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit f700bfa9fa3eef666012be59ff3c3703909ed475
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 04 10:16:10 2020
Add docs on FragmentFactory to secondary dialogfragment constructor
In the docs for the DialogFragment constructor that takes a layourId we
should mention how uses can use this constructor if with a FragmentFactory.
Test: ./gradlew bOS
Bug: 153042497
Change-Id: Ic7c9402fc609b1d1f458bc5fd9a68be4ec580515
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
https://android-review.googlesource.com/1301714
Branch: androidx-master-dev
commit f700bfa9fa3eef666012be59ff3c3703909ed475
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 04 10:16:10 2020
Add docs on FragmentFactory to secondary dialogfragment constructor
In the docs for the DialogFragment constructor that takes a layourId we
should mention how uses can use this constructor if with a FragmentFactory.
Test: ./gradlew bOS
Bug: 153042497
Change-Id: Ic7c9402fc609b1d1f458bc5fd9a68be4ec580515
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
jb...@google.com
Needed to fix this for DialogFragment as well.
Description
It would be nice to better explain that when implementing a `Fragment` with a `layoutId`, client should make sure they always call `super(int)`
`class MyFragment : Fragment(R.layout.fragment_my)` which basically indicates that `MyFragment` has a no-arg constructor (used by the default `FragmentFactory`) that will always set its `contentLayoutId` to `R.Layout.fragment_my`.