Make it a bit clearer how to use alternate constructor of Fragment [153042497]

Fixed

Bug

Status Update

No update yet.

Description

cy...@gmail.com

created issue #1

Apr 2, 2020 09:46AM

When reading `Fragment` constructors documentation, it is indicated it is possible to use a different `FragmentFactory` and that the default one will use no-arg constructor.

It would be nice to better explain that when implementing a `Fragment` with a `layoutId`, client should make sure they always call `super(int)`

`class MyFragment : Fragment(R.layout.fragment_my)` which basically indicates that `MyFragment` has a no-arg constructor (used by the default `FragmentFactory`) that will always set its `contentLayoutId` to `R.Layout.fragment_my`.

Comments

il...@google.com <il...@google.com> Apr 2, 2020 09:53PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2May 2, 2020 01:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit 57ca221882695bd6a52549f4d9ea3b812e6fe87c
Author: Simon Schiller <simonschiller@users.noreply.github.com>
Date: Mon Mar 22 16:09:30 2021

[GH] [FragmentStrictMode] Detect <fragment> tag usage

## Proposed Changes

- Detect `<fragment>` tag usage inside XML layouts

## Testing

Test: See `FragmentStrictModeTest#detectFragmentTagUsage`

## Issues Fixed

Fixes: 153738235

This is an imported pull request from

https://github.com/androidx/androidx/pull/141.

Resolves #141
Github-Pr-Head-Sha: 4ea052596e4341b9f11bcf335e2bc38045a91f19
GitOrigin-RevId: 62e7487aa4874eef6bb556490e193717cf937251
Change-Id: Iae48578e85e4e4897f806d7ade2e2a660adf9479

M fragment/fragment/api/public_plus_experimental_current.txt
M fragment/fragment/api/restricted_current.txt
M fragment/fragment/src/androidTest/java/androidx/fragment/app/strictmode/FragmentStrictModeTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentLayoutInflaterFactory.java
M fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentStrictMode.java
A fragment/fragment/src/main/java/androidx/fragment/app/strictmode/FragmentTagUsageViolation.java

https://android-review.googlesource.com/1649748

jb...@google.com <jb...@google.com> #3May 4, 2020 03:28PM

Marked as fixed.

This has been fixed internally and will be available in the Fragment 1.3.0-alpha05 release.

jb...@google.com <jb...@google.com> May 4, 2020 05:11PM

Status: Assigned (reopened)

ap...@google.com <ap...@google.com> #4May 4, 2020 05:57PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit f700bfa9fa3eef666012be59ff3c3703909ed475
Author: Jeremy Woods <jbwoods@google.com>
Date: Mon May 04 10:16:10 2020

Add docs on FragmentFactory to secondary dialogfragment constructor

In the docs for the DialogFragment constructor that takes a layourId we
should mention how uses can use this constructor if with a FragmentFactory.

Test: ./gradlew bOS
Bug: 153042497
Change-Id: Ic7c9402fc609b1d1f458bc5fd9a68be4ec580515

M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java

https://android-review.googlesource.com/1301714

jb...@google.com <jb...@google.com> #5May 4, 2020 06:20PM

Marked as fixed.

Needed to fix this for DialogFragment as well.

Issue 153042497