CameraView, strange video resolution [153237864]

Fixed

Bug

Status Update

No update yet.

Description

ic...@gmail.com

created issue #1

Apr 5, 2020 09:38AM

CAMERAX VERSION: 1.0.0-beta02, CameraView: 1.0.0-alpha09

ANDROID OS BUILD NUMBER: QQ2A.200305.002

DEVICE NAME: Pixel 3a

DESCRIPTION:
1) I use CameraView from CameraX library, for recording video. Earlier I used old library version 1.0.0-alpha08 and default resolution(1920 х 1080) suited me, but that version had some issues. For now I'm using 1.0.0-beta02, I get very strange resolution (1600 x 1200 - Pixel 3a 1400x1200 - Huawei p20 lite).
2) And I can't find any settings of video recording process for CameraView. How can i set, resolution, bitrate, framerate, or just HIGHT, LOW, MEDIUM preset?

STEPS TO REPRODUCE:
1. Set CameraView in layout.
2. Call startRecording() fun.
3. Check saved file, it will has resolution 1600x1200

OBSERVED RESULTS: strange resolution 1600x1200

EXPECTED RESULTS: minimum, as earlier 1920x1080, it is desirable that I myself can set the quality

REPRODUCIBILITY: 5 of 5

ADDITIONAL INFORMATION: Log about format

D/CCodecConfig: c2 config diff is Dict {
c2::u32 algo.bitrate-mode.value = 3
c2::i32 algo.priority.value = -1
c2::u32 algo.quality.value = 50
c2::float algo.rate.value = 4.2039e-44
c2::u32 coded.bitrate.value = 20000000
c2::float coded.frame-rate.value = 30
c2::u32 coded.pl.level = 20480
c2::u32 coded.pl.profile = 20480
c2::u32 coded.vui.color.matrix = 0
c2::u32 coded.vui.color.primaries = 0
c2::u32 coded.vui.color.range = 0
c2::u32 coded.vui.color.transfer = 0
c2::i32 coding.gop.intra-period = 1
c2::u32 coding.request-sync-frame.value = 0
Buffer coding.temporal-layering = {
00000000: 10 00 00 00 07 20 01 52 01 00 00 00 00 00 00 00 ..... .R........
}
c2::u32 default.color.matrix = 0
c2::u32 default.color.primaries = 0
c2::u32 default.color.range = 0
c2::u32 default.color.transfer = 0
c2::u32 input.delay.value = 8
string input.media-type.value = "video/raw"
c2::u32 output.buffers.prepend-header.value = 2
c2::u32 output.delay.value = 8
string output.media-type.value = "
D/CCodecConfig: no c2 equivalents for encoder
D/CCodecConfig: c2 config diff is c2::u32 coded.bitrate.value = 8388608
c2::i32 coding.gop.intra-period = 30
c2::u32 raw.pixel-format.value = 34
c2::u32 raw.size.height = 1200
c2::u32 raw.size.width = 1600

D/CCodec: setup formats input: AMessage(what = 0x00000000) = {
Rect crop(0, 0, 1599, 1199)
int32_t color-standard = 0
int32_t color-range = 0
int32_t color-transfer = 0
int32_t frame-rate = 30
int32_t height = 1200
int32_t i-frame-period = 30
string mime = "video/raw"
int32_t prepend-sps-pps-to-idr-frames = 1
int32_t priority = 1
int32_t width = 1600
int32_t android._dataspace = 0
int32_t android._color-format = 2130708361
int32_t color-format = 2130708361
} and output: AMessage(what = 0x00000000) = {
int32_t bitrate = 8388608
int32_t bitrate-mode = 1
Rect crop(0, 0, 1599, 1199)
int32_t width = 1600
int32_t color-standard = 0
int32_t color-range = 0
int32_t color-transfer = 0
int32_t frame-rate = 30
int32_t height = 1200
int32_t i-frame-period = 30
int32_t level = 1
int32_t max-bitrate = 8388608
string mime = "video/avc"
int32_t prepend-sps-pps-to-idr-frames = 1
int32_t priority = 1
int32_t profile = 1
}

D/CCodec: input format changed to AMessage(what = 0x00000000) = {
Rect crop(0, 0, 1599, 1199)
int32_t color-standard = 1
int32_t color-range = 2
int32_t color-transfer = 3
int32_t frame-rate = 30
int32_t height = 1200
int32_t i-frame-period = 30
string mime = "video/raw"
int32_t prepend-sps-pps-to-idr-frames = 1
int32_t priority = 1
int32_t width = 1600
int32_t android._dataspace = 260
int32_t android._color-format = 2130708361
int32_t color-format = 2130708361
}

Comments

er...@google.com <er...@google.com> #2Apr 6, 2020 09:59PM

Reassigned to ic...@gmail.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ic...@gmail.com <ic...@gmail.com> #3Apr 7, 2020 05:45AM

Hi, yes sure, CameraView is taking up entire screen.
Thanks!

er...@google.com <er...@google.com> Apr 7, 2020 08:49PM

Reassigned to ca...@google.com.

ch...@google.com <ch...@google.com> Apr 10, 2020 01:06AM

Reassigned to ch...@google.com.

ap...@google.com <ap...@google.com> #4Apr 29, 2020 07:40AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42f8e2cb8d62518f22be5ee87297ce5c54169034
Author: charcoalchen <charcoalchen@google.com>
Date: Sun Apr 12 18:06:25 2020

Set CameraView's VideoCapture aspect ratio as 16:9

Relnote: "Fixed the VideoCapture's default aspect ratio to be 16:9 in CameraView."

Bug:

b/153237864

Test: ./gradlew bOS & maunal test
Change-Id: Ie6a7bf344e6e08b25e47109557288b07187b3f7a

M camera/camera-view/src/main/java/androidx/camera/view/CameraXModule.java

https://android-review.googlesource.com/1285093

ch...@google.com <ch...@google.com> #5Apr 29, 2020 07:53AM

Marked as fixed.

VideoCapture in CameraView's default aspect ratio has been updated as 16:9.
This fix should be included in CameraX's next release.

Issue 153237864