Fixed
Status Update
Comments
su...@google.com <su...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit e1b4be5ef6f009bd83740cdb2be1877511475c46
Author: pingxuanli <pingxuanli@google.com>
Date: Mon Aug 15 13:45:21 2022
Removed the restriction for Upsert annotation
Bug: 241964353
Test: Tests for @Upsert Annotation are in `UpsertTest.kt` file
Relnote: Adding @Upsert Annotation, which attempt to insert an entity when there is no conflict and update the entity if there is a conflict.
Change-Id: I7aaab5416551ed70e0130a60b6b629a531757a16
M room/room-common/api/current.txt
M room/room-common/src/main/java/androidx/room/Upsert.kt
M room/room-common/api/public_plus_experimental_current.txt
M room/room-common/api/restricted_current.txt
https://android-review.googlesource.com/2184904
Branch: androidx-main
commit e1b4be5ef6f009bd83740cdb2be1877511475c46
Author: pingxuanli <pingxuanli@google.com>
Date: Mon Aug 15 13:45:21 2022
Removed the restriction for Upsert annotation
Bug: 241964353
Test: Tests for @Upsert Annotation are in `UpsertTest.kt` file
Relnote: Adding @Upsert Annotation, which attempt to insert an entity when there is no conflict and update the entity if there is a conflict.
Change-Id: I7aaab5416551ed70e0130a60b6b629a531757a16
M room/room-common/api/current.txt
M room/room-common/src/main/java/androidx/room/Upsert.kt
M room/room-common/api/public_plus_experimental_current.txt
M room/room-common/api/restricted_current.txt
so...@gmail.com <so...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 40e15ece328da2b94a516610ecda8541ad776086
Author: pingxuanli <pingxuanli@google.com>
Date: Tue Aug 16 16:56:06 2022
Adding SuspendingQueryTest for @Upsert including upsert without returns and upsert with Long and List<Long> as return types
Bug: 241964353
Test: The tests for upsert with suspend is inside file `SuspendingQueryTest`
Change-Id: I4996de64884651c245ab144e3481d027382c86e3
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendingQueryTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
https://android-review.googlesource.com/2188580
Branch: androidx-main
commit 40e15ece328da2b94a516610ecda8541ad776086
Author: pingxuanli <pingxuanli@google.com>
Date: Tue Aug 16 16:56:06 2022
Adding SuspendingQueryTest for @Upsert including upsert without returns and upsert with Long and List<Long> as return types
Bug: 241964353
Test: The tests for upsert with suspend is inside file `SuspendingQueryTest`
Change-Id: I4996de64884651c245ab144e3481d027382c86e3
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/SuspendingQueryTest.kt
M room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/dao/BooksDao.kt
so...@gmail.com <so...@gmail.com> #5
Thanks for reconsidering. :)
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 060fd6070a84bac1406bce3f3566046d03ebd58f
Author: Sumir Kataria <sumir@google.com>
Date: Tue Apr 07 09:59:46 2020
Ignore SecurityExceptions in NetworkStateTracker registration.
There is nothing we can do about this - they only happen in
certain devices. This is similar to us ignoring ISEs on some
devices. NetworkStateTracker is only used for GreedyScheduler.
Fixes: 153246136
Test: N/A
Change-Id: I0284fa87623d7dd7424dae5318b34fb4f4607303
M work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java
https://android-review.googlesource.com/1280813
Branch: androidx-master-dev
commit 060fd6070a84bac1406bce3f3566046d03ebd58f
Author: Sumir Kataria <sumir@google.com>
Date: Tue Apr 07 09:59:46 2020
Ignore SecurityExceptions in NetworkStateTracker registration.
There is nothing we can do about this - they only happen in
certain devices. This is similar to us ignoring ISEs on some
devices. NetworkStateTracker is only used for GreedyScheduler.
Fixes: 153246136
Test: N/A
Change-Id: I0284fa87623d7dd7424dae5318b34fb4f4607303
M work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java
la...@gmail.com <la...@gmail.com> #7
java.lang.SecurityException: Can't install packages while in secure FRP
at android.os.Parcel.createExceptionOrNull(Parcel.java:2426)
at android.os.Parcel.createException(Parcel.java:2410)
at android.os.Parcel.readException(Parcel.java:2393)
at android.os.Parcel.readException(Parcel.java:2335)
at android.content.pm.IPackageInstallerSession$Stub$Proxy.commit(IPackageInstallerSession.java:794)
at android.content.pm.PackageInstaller$Session.commit(PackageInstaller.java:1550)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:371)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:293)
at android.os.AsyncTask.finish(AsyncTask.java:771)
at android.os.AsyncTask.access$900(AsyncTask.java:199)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8302)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.pm.PackageInstallerSession.markAsSealed(PackageInstallerSession.java:2097)
at com.android.server.pm.PackageInstallerSession.commit(PackageInstallerSession.java:1835)
at android.content.pm.IPackageInstallerSession$Stub.onTransact(IPackageInstallerSession.java:385)
at android.os.Binder.execTransactInternal(Binder.java:1179)
at android.os.Binder.execTransact(Binder.java:1143)
at android.os.Parcel.createExceptionOrNull(Parcel.java:2426)
at android.os.Parcel.createException(Parcel.java:2410)
at android.os.Parcel.readException(Parcel.java:2393)
at android.os.Parcel.readException(Parcel.java:2335)
at android.content.pm.IPackageInstallerSession$Stub$Proxy.commit(IPackageInstallerSession.java:794)
at android.content.pm.PackageInstaller$Session.commit(PackageInstaller.java:1550)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:371)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:293)
at android.os.AsyncTask.finish(AsyncTask.java:771)
at android.os.AsyncTask.access$900(AsyncTask.java:199)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8302)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.pm.PackageInstallerSession.markAsSealed(PackageInstallerSession.java:2097)
at com.android.server.pm.PackageInstallerSession.commit(PackageInstallerSession.java:1835)
at android.content.pm.IPackageInstallerSession$Stub.onTransact(IPackageInstallerSession.java:385)
at android.os.Binder.execTransactInternal(Binder.java:1179)
at android.os.Binder.execTransact(Binder.java:1143)
Description
Version used: 2.2.0
implementation "androidx.work:work-runtime:2.2.0"
implementation "androidx.work:work-runtime-ktx:2.2.0"
implementation "androidx.work:work-rxjava2:2.2.0"
Devices/Android versions reproduced on:
W1450 / Android 7.0 (NetworkType does not matter.)
It occurs on specific device model only.
And about 600 crashes occur per month.
The followings are stack trace.
Please check if it can be fixed.
--------------------------------------------------------------------------------------------------------
java.lang.SecurityException: {PACKAGE_NAME} was not granted either of these permissions: android.permission.CHANGE_NETWORK_STATE, android.permission.WRITE_SETTINGS.
at android.os.Parcel.readException(Parcel.java:1683)
at android.os.Parcel.readException(Parcel.java:1636)
at android.net.IConnectivityManager$Stub$Proxy.requestNetwork(IConnectivityManager.java:2343)
at android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:2917)
at android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:3197)
at androidx.work.impl.constraints.trackers.NetworkStateTracker.startTracking(NetworkStateTracker.java:3)
at androidx.work.impl.constraints.trackers.ConstraintTracker.addListener(ConstraintTracker.java:8)
at androidx.work.impl.constraints.controllers.ConstraintController.replace(ConstraintController.java:7)
at androidx.work.impl.constraints.WorkConstraintsTracker.replace(WorkConstraintsTracker.java:5)
at androidx.work.impl.background.greedy.GreedyScheduler.schedule(GreedyScheduler.java:21)
at androidx.work.impl.Schedulers.schedule(Schedulers.java:15)
at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork(WorkManagerImpl.java:4)
at androidx.work.impl.utils.ForceStopRunnable.run(ForceStopRunnable.java:9)
at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:1)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)
--------------------------------------------------------------------------------------------------------