Fixed
Status Update
Comments
su...@google.com <su...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
so...@gmail.com <so...@gmail.com> #3
su...@google.com <su...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically ( b/140759491 ).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
so...@gmail.com <so...@gmail.com> #5
Thanks for reconsidering. :)
ap...@google.com <ap...@google.com> #6
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 060fd6070a84bac1406bce3f3566046d03ebd58f
Author: Sumir Kataria <sumir@google.com>
Date: Tue Apr 07 09:59:46 2020
Ignore SecurityExceptions in NetworkStateTracker registration.
There is nothing we can do about this - they only happen in
certain devices. This is similar to us ignoring ISEs on some
devices. NetworkStateTracker is only used for GreedyScheduler.
Fixes: 153246136
Test: N/A
Change-Id: I0284fa87623d7dd7424dae5318b34fb4f4607303
M work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java
https://android-review.googlesource.com/1280813
Branch: androidx-master-dev
commit 060fd6070a84bac1406bce3f3566046d03ebd58f
Author: Sumir Kataria <sumir@google.com>
Date: Tue Apr 07 09:59:46 2020
Ignore SecurityExceptions in NetworkStateTracker registration.
There is nothing we can do about this - they only happen in
certain devices. This is similar to us ignoring ISEs on some
devices. NetworkStateTracker is only used for GreedyScheduler.
Fixes: 153246136
Test: N/A
Change-Id: I0284fa87623d7dd7424dae5318b34fb4f4607303
M work/workmanager/src/main/java/androidx/work/impl/constraints/trackers/NetworkStateTracker.java
la...@gmail.com <la...@gmail.com> #7
java.lang.SecurityException: Can't install packages while in secure FRP
at android.os.Parcel.createExceptionOrNull(Parcel.java:2426)
at android.os.Parcel.createException(Parcel.java:2410)
at android.os.Parcel.readException(Parcel.java:2393)
at android.os.Parcel.readException(Parcel.java:2335)
at android.content.pm.IPackageInstallerSession$Stub$Proxy.commit(IPackageInstallerSession.java:794)
at android.content.pm.PackageInstaller$Session.commit(PackageInstaller.java:1550)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:371)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:293)
at android.os.AsyncTask.finish(AsyncTask.java:771)
at android.os.AsyncTask.access$900(AsyncTask.java:199)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8302)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.pm.PackageInstallerSession.markAsSealed(PackageInstallerSession.java:2097)
at com.android.server.pm.PackageInstallerSession.commit(PackageInstallerSession.java:1835)
at android.content.pm.IPackageInstallerSession$Stub.onTransact(IPackageInstallerSession.java:385)
at android.os.Binder.execTransactInternal(Binder.java:1179)
at android.os.Binder.execTransact(Binder.java:1143)
at android.os.Parcel.createExceptionOrNull(Parcel.java:2426)
at android.os.Parcel.createException(Parcel.java:2410)
at android.os.Parcel.readException(Parcel.java:2393)
at android.os.Parcel.readException(Parcel.java:2335)
at android.content.pm.IPackageInstallerSession$Stub$Proxy.commit(IPackageInstallerSession.java:794)
at android.content.pm.PackageInstaller$Session.commit(PackageInstaller.java:1550)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:371)
at com.android.packageinstaller.InstallInstalling$InstallingAsyncTask.onPostExecute(InstallInstalling.java:293)
at android.os.AsyncTask.finish(AsyncTask.java:771)
at android.os.AsyncTask.access$900(AsyncTask.java:199)
at android.os.AsyncTask$InternalHandler.handleMessage(AsyncTask.java:788)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:210)
at android.os.Looper.loop(Looper.java:299)
at android.app.ActivityThread.main(ActivityThread.java:8302)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:556)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1037)
Caused by: android.os.RemoteException: Remote stack trace:
at com.android.server.pm.PackageInstallerSession.markAsSealed(PackageInstallerSession.java:2097)
at com.android.server.pm.PackageInstallerSession.commit(PackageInstallerSession.java:1835)
at android.content.pm.IPackageInstallerSession$Stub.onTransact(IPackageInstallerSession.java:385)
at android.os.Binder.execTransactInternal(Binder.java:1179)
at android.os.Binder.execTransact(Binder.java:1143)
Description
Version used: 2.2.0
implementation "androidx.work:work-runtime:2.2.0"
implementation "androidx.work:work-runtime-ktx:2.2.0"
implementation "androidx.work:work-rxjava2:2.2.0"
Devices/Android versions reproduced on:
W1450 / Android 7.0 (NetworkType does not matter.)
It occurs on specific device model only.
And about 600 crashes occur per month.
The followings are stack trace.
Please check if it can be fixed.
--------------------------------------------------------------------------------------------------------
java.lang.SecurityException: {PACKAGE_NAME} was not granted either of these permissions: android.permission.CHANGE_NETWORK_STATE, android.permission.WRITE_SETTINGS.
at android.os.Parcel.readException(Parcel.java:1683)
at android.os.Parcel.readException(Parcel.java:1636)
at android.net.IConnectivityManager$Stub$Proxy.requestNetwork(IConnectivityManager.java:2343)
at android.net.ConnectivityManager.sendRequestForNetwork(ConnectivityManager.java:2917)
at android.net.ConnectivityManager.registerDefaultNetworkCallback(ConnectivityManager.java:3197)
at androidx.work.impl.constraints.trackers.NetworkStateTracker.startTracking(NetworkStateTracker.java:3)
at androidx.work.impl.constraints.trackers.ConstraintTracker.addListener(ConstraintTracker.java:8)
at androidx.work.impl.constraints.controllers.ConstraintController.replace(ConstraintController.java:7)
at androidx.work.impl.constraints.WorkConstraintsTracker.replace(WorkConstraintsTracker.java:5)
at androidx.work.impl.background.greedy.GreedyScheduler.schedule(GreedyScheduler.java:21)
at androidx.work.impl.Schedulers.schedule(Schedulers.java:15)
at androidx.work.impl.WorkManagerImpl.rescheduleEligibleWork(WorkManagerImpl.java:4)
at androidx.work.impl.utils.ForceStopRunnable.run(ForceStopRunnable.java:9)
at androidx.work.impl.utils.SerialExecutor$Task.run(SerialExecutor.java:1)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
at java.lang.Thread.run(Thread.java:761)
--------------------------------------------------------------------------------------------------------