Set signingConfig signingConfig.debug for release build type automatically in gradle plugin [153583269]

Fixed

Feature Request

Status Update

No update yet.

Description

du...@google.com

created issue #1

Apr 8, 2020 09:30PM

Reduces a bit of setup friction!

Comments

cc...@google.com <cc...@google.com> #2Apr 9, 2020 02:33PM

What exactly fails if you don't have the signing config set? Can we file a bug on AGP to do this automatically instead, or at least tell you to do it when the failure happens? (The latter might be preferable, since the default config can't be shipped to Play Store since it's not properly signed)

I'm a little wary of making this the plugin's responsibility long term, since it's invisible, and unclear why the behavior is different for benchmarks (when it feels like it shouldn't be).

du...@google.com <du...@google.com> #3Apr 17, 2020 08:10AM

I filed this in response to your comment here: https://github.com/android/architecture-components-samples/pull/825

Basically setting testBuildType to release (which we do in the plugin) is annoying because it requires you to also set a signingConfig unless you also set signingConfig signingConfig.debug in gradle. testBuildType being set to release is already somewhat invisible, so we should also invisibly fix the issue for users right? Alternatively, we could just remove this from the plugin and have it be part of the template / explicitly require user to define in gradle.

cc...@google.com <cc...@google.com> #4Apr 17, 2020 03:23PM

To clarify #2, I agree this change makes sense, I'm just thinking that we should also ask AGP to consider making that signing config the default. That way in the long term, we don't need this, and the plugin does less tweaking of your settings.

It would move the signing hurdle for developers from running the release build for the first time to store upload time, but I think that's good anyway. It enables them to run their release app locally for profiling, or R8 validation. At minimum, this makes sense for a library module test APK, since you'll never upload it to the store anyway - there's no reason it can't be signed with debug keys.

du...@google.com <du...@google.com> #5Apr 27, 2020 10:20PM

I think this kind of logic AGP would only want to do for benchmark modules, and it would only be able to know by applied plugin or dependency. It seems like something that would depend on whether benchmark modules are considered a 1st-class citizen in AGP, but otherwise I'm not too sure. Should we also duplicate this change in the studio template if we apply it in the benchmark plugin?

du...@google.com <du...@google.com> Apr 28, 2020 02:13AM

Accepted by du...@google.com.

cc...@google.com <cc...@google.com> #6Apr 28, 2020 03:47PM

I had forgotten, I did file a bug about this behavior to Studio a while back, added some clarification to that bug:

b/111118208

ap...@google.com <ap...@google.com> #7Apr 28, 2020 06:06PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 8e4b9c9bbba86dc0d440499d7c433cf47e271ef4
Author: Dustin Lam <dustinlam@google.com>
Date: Mon Apr 27 17:45:57 2020

Set signingConfig for benchmark buildTypes to debug by default

Fixes: 153583269
Test: ./gradlew benchmark:benchmark-gradle-plugin:test
Change-Id: I4b42d5a0a44a2c165ad82998fc1dc7bcbf5b8dc1

M benchmark/gradle-plugin/src/main/kotlin/androidx/benchmark/gradle/BenchmarkPlugin.kt
M benchmark/gradle-plugin/src/test/kotlin/androidx/benchmark/gradle/BenchmarkPluginTest.kt

https://android-review.googlesource.com/1296945

cc...@google.com <cc...@google.com> #8Jun 3, 2020 08:12PM

Note that AGP landed a change (coming in a 4.1 alpha) to make this the default behavior, so eventually we can remove this behavior on our side: b/111118208