setMenuVisibility does not control child fragments' menus [153593580]

Fixed

Bug

Status Update

No update yet.

Description

lu...@ozrunways.com

created issue #1

Apr 9, 2020 03:52AM

The documentation for the androidx.fragment.app.Fragment#setMenuVisibility suggests that it controls whether the "fragment's menu" items should be shown. The current implementation does not consider child fragments' menu items to be part of their parent fragment's menu items, I think this is unexpected.

Current behavior: calling setMenuVisibility(false) suppresses calls to that fragment's onCreateOptionsMenu, but still dispatches calls to child fragments' onCreateOptionsMenu methods.
Desired behavior: calling setMenuVisibility(false) also suppresses calls to child fragments' onCreateOptionsMenu methods.

This would simplify using FragmentStateAdapter with nested fragments. Currently we have to manually propagate setMenuVisibility calls down from the parent fragment in the adapter, to it's children. Without doing that, menu items from the child fragments are not removed as the active item changes. I found a bug report with a similar workaround for this here:

https://issuetracker.google.com/issues/118392609

If this behavior isn't changed, can I suggest changing the documentation for the setMenuVisibility method to make it clear that it doesn't include child fragments.

Component used: Fragment
Version used: 1.3.0-alpha03
Devices/Android versions reproduced on: Emulator, Android API 29

Comments

il...@google.com <il...@google.com> Apr 9, 2020 09:36PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #2Apr 13, 2020 10:05PM

Project: platform/frameworks/support
Branch: androidx-main

commit b697d397d051f91a6f6ed95a55af421f048f3c89
Author: Sanura Njaka <sanura@google.com>
Date: Wed Aug 02 12:16:12 2023

Folding lifecycle-livedata-core-ktx back into main
module

Now that Lifecycle tests are written in kotlin, LiveDataTest
can be moved from lifecycle-livedata-core-ktx into LiveDataTest
within the main lifecycle-livedata-core module.

Test: ./gradlew bOS
Bug: 274800183
Change-Id: I98806ad751bd674a554de665e0e16bf05d67900d

D lifecycle/lifecycle-livedata-core-ktx/src/test/java/androidx/lifecycle/LiveDataTest.kt
M lifecycle/lifecycle-livedata-core/src/test/java/androidx/lifecycle/LiveDataTest.kt

https://android-review.googlesource.com/2690010

jb...@google.com <jb...@google.com> #3Apr 14, 2020 12:38AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit cd3c1d7751462b5e42ae54e2d68299f955dcb6c3
Author: Sanura Njaka <sanura@google.com>
Date: Mon Aug 07 07:34:20 2023

Folding lifecycle-livedata-ktx back into main
module

Now that Lifecycle tests are written in kotlin, all files in lifecycle-livedata-ktx can now be added into the main lifecycle-livedata module.

RelNote: "All files from the lifecycle-livedata-ktx modules have been moved into the main lifecycle-livedata module"
Test: ./gradlew bOS
Bug: 274800183
Change-Id: I10c6f70c82a64e80eec704f548911f42bdd0b56a

M lifecycle/lifecycle-livedata-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata/api/current.txt
M lifecycle/lifecycle-livedata/api/restricted_current.txt
M lifecycle/lifecycle-livedata/build.gradle
M lifecycle/lifecycle-livedata/src/androidTest/java/androidx.lifecycle/FlowAsLiveDataIntegrationTest.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata/src/main/java/androidx/lifecycle/FlowLiveData.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataFlowJavaTest.java
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/ScopesRule.kt

https://android-review.googlesource.com/2695173

lu...@ozrunways.com <lu...@ozrunways.com> #4Apr 14, 2020 03:09AM

Project: platform/frameworks/support
Branch: androidx-main

commit 32c1896b0506529674f03076a1141daaa0749b28
Author: Sanura Njaka <sanura@google.com>
Date: Tue Aug 22 11:20:50 2023

Moving ScopesRule into util package

ScopesRule.kt will now be included in lifecycle-livedata's util package

Test: ./gradlew bOS
BUg: 274800183
Change-Id: I2df34eebffcdacc716ce0235e29601436918f955

M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/FlowAsLiveDataTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/LiveDataAsFlowTest.kt
M lifecycle/lifecycle-livedata/src/test/java/androidx/lifecycle/util/ScopesRule.kt

https://android-review.googlesource.com/2721674

an...@google.com <an...@google.com> #5May 26, 2020 10:23PM

Project: platform/frameworks/support
Branch: androidx-main

commit 4140c78328013f4fea4bd48f286c46a98c358270
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 14:43:43 2024

Move `lifecycle-viewmodel-ktx` source to the base module

* Transferred source code from `lifecycle-viewmodel-ktx` to the main `lifecycle-viewmodel` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.
* Renamed the file from `ViewModel` to `ViewModelCoroutineScope` to reflect the content: coroutines support. Use `file:JvmName("ViewModelKt")` to maintain source compatibility.
* Add a resolutionStrategy to `:playground` and `:presentation` in `:tv:integration-tests` to resolve "minifyReleaseWithR8 FAILED: Class is defined multiple times" issue caused by moving classes from `-ktx` to the base module.

RelNote: "The `lifecycle-viewmodel-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: ViewModelCoroutinesTest
Change-Id: Id787b6db6817e69e4ec50748a07ccdbef074e99d

A lifecycle/lifecycle-viewmodel-ktx/api/current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/current.txt
A lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-viewmodel-ktx/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel-ktx/build.gradle
M lifecycle/lifecycle-viewmodel/api/current.txt
M lifecycle/lifecycle-viewmodel/api/restricted_current.txt
M lifecycle/lifecycle-viewmodel/build.gradle
M lifecycle/lifecycle-viewmodel/src/androidTest/java/androidx/lifecycle/ViewModelCoroutineScopeTest.kt
M lifecycle/lifecycle-viewmodel/src/main/java/androidx/lifecycle/ViewModelCoroutineScope.kt
M tv/integration-tests/playground/build.gradle
M tv/integration-tests/presentation/build.gradle

https://android-review.googlesource.com/2930010

il...@google.com <il...@google.com> #6May 27, 2020 05:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit ce327843c4c6bfeb3410a1203e0e2aac0f0a59cc
Author: Marcello Galhardo <mgalhardo@google.com>
Date: Fri Jan 26 16:21:38 2024

Move `lifecycle-livedata-core-ktx` source to the base module

* Transferred source code from `lifecycle-livedata-core-ktx` to the base `lifecycle-livedata-core` module.
* Kotlin STD Lib is now a dependency in the base AndroidX Lifecycle artifacts, separate `-ktx` modules for Kotlin extensions are no longer needed.

RelNote: "The `lifecycle-livedata-core-ktx` kotlin extensions have now been moved to the base lifecycle module."
Bug: 274800183
Test: manual
Change-Id: I54a3d4346b4a9c5861f5f3bdb0079dbb27f29668

A lifecycle/lifecycle-livedata-core-ktx/api/current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/current.txt
A lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.ignore
M lifecycle/lifecycle-livedata-core-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core-ktx/build.gradle
M lifecycle/lifecycle-livedata-core/api/current.txt
M lifecycle/lifecycle-livedata-core/api/restricted_current.txt
M lifecycle/lifecycle-livedata-core/src/main/java/androidx/lifecycle/LiveData.kt

https://android-review.googlesource.com/2927827

Issue 153593580