Make it possible to provide your own ActivityTestRule to AndroidComposeTestRule [153623653]

Fixed

Feature Request

Status Update

No update yet.

Description

je...@google.com

created issue #1

Apr 9, 2020 09:36AM

Since https://r.android.com/1282381 it is mandatory to use ComposeTestRule. This can be a problem for teams that have a custom ActivityTestRule with which they want to control their app's Activity, since they are now forced to use the rule created by AndroidComposeTestRule.

Solve this by adding the ActivityTestRule as a parameter to the AndroidComposeTestRule.

Comments

pa...@google.com <pa...@google.com> #2Apr 9, 2020 10:56AM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

je...@google.com <je...@google.com> #3Apr 9, 2020 02:36PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ap...@google.com <ap...@google.com> #4Apr 15, 2020 01:56PM

deleted

je...@google.com <je...@google.com> #5Apr 15, 2020 06:40PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

je...@google.com <je...@google.com> Nov 10, 2020 02:23PM

Reassigned to pa...@google.com.

ap...@google.com <ap...@google.com> #6Nov 11, 2020 11:09AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 5b0bebd168fded3237342e7aa9e7f039c5182dd2
Author: Filip Pavlis <pavlis@google.com>
Date: Mon Nov 09 18:01:52 2020

Removed dependency on specific activity rule

This removes dependency on ActivityScenarioRule from
AndroidComposeTestRule. Meaning that compose test rule can be used with
any lauchner from now on.

Test: N/A
Bug: 153623653
Bug: 154135019
Relnote: "AndroidComposeTestRule can now accept custom activity
launchers"

Change-Id: Ib828876d918f3f091b622bbeb62dd1a31c75badb

M compose/test-utils/src/androidAndroidTest/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunnerTest.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/TestRuleExtensions.kt
M compose/ui/ui-test-junit4/api/current.txt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/api/restricted_current.txt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/AndroidComposeTestRule.kt
D compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/android/AndroidComposeTestRule.kt

https://android-review.googlesource.com/1492916

Issue 153623653