Add onSizeChanged modifier [154108792]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Apr 15, 2020 03:06PM

Currently I'm using Modifier.onPositioned a lot to know the laid out size of a node, but onPositioned is wasteful for this, especially when it's in a scroller.

Ideally I want just a onSizeChanged modifier to know only when the size changes.

Comments

ma...@google.com <ma...@google.com> #2Apr 15, 2020 03:12PM

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

ch...@google.com <ch...@google.com> #3Apr 15, 2020 03:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

ma...@google.com <ma...@google.com> #4Apr 15, 2020 03:24PM

Reassigned to mo...@google.com.

deleted

mo...@google.com <mo...@google.com> #5Apr 15, 2020 06:01PM

Reassigned to ch...@google.com.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

ch...@google.com <ch...@google.com> #6Apr 16, 2020 08:09AM

Reassigned to mo...@google.com.

Yep, that's exactly what I'd like in the library.

I can also see the benefit of having another modifier to know the content size within the parent too.

ch...@google.com <ch...@google.com> #7Apr 16, 2020 12:44PM

Just tried the code above but modifySize doesn't seem to be in LayoutModifier2 (it is in the deprecated LayoutModifier though)

mo...@google.com <mo...@google.com> Jul 13, 2020 09:47PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #8Sep 1, 2020 11:12PM

Chris, I'd like to make a sample for using OnSizeChanged. Can you give me a short example of how it would be used?

ch...@google.com <ch...@google.com> #9Sep 14, 2020 10:19AM

Here's an example: https://github.com/chrisbanes/tivi/blob/cb/discover-compose/ui-discover/src/main/java/app/tivi/home/discover/Discover.kt#L243

Basically I need to know the height of the app bar, to be able to push down content (y-axis) to be visually below.

Message last modified on Sep 14, 2020 10:20AM

mo...@google.com <mo...@google.com> #10Sep 21, 2020 10:05PM

Nice! I've put in a simplified version of that.

ap...@google.com <ap...@google.com> #11Sep 22, 2020 10:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9209f5d65524cf83c0860459955bd83c5615a817
Author: George Mount <mount@google.com>
Date: Tue Sep 01 14:55:57 2020

Add onSizeChanged() and OnRemeasuredModifier

Added a new modifier to make it faster to notify only when a
layout's content size changes. This avoids the down-hierarchy
notifications required when using onPositioned.

Relnote: "Added OnRemeasuredModifier and onSizeChanged() to
receive a callback when content layout has been remeasured and
the size has changed, respectively."

Fixes: 154108792
Bug: 162351735

Test: OnSizeChangedTest
Change-Id: I657cf033de811e9279a2b2079933ca0bd89e5e60

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/OnSizeChangedSamples.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnSizeChangedTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/OnRemeasuredModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt

https://android-review.googlesource.com/1418715