Add onSizeChanged modifier [154108792]

Fixed

Feature Request

Status Update

No update yet.

Description

ch...@google.com

created issue #1

Apr 15, 2020 03:06PM

Currently I'm using Modifier.onPositioned a lot to know the laid out size of a node, but onPositioned is wasteful for this, especially when it's in a scroller.

Ideally I want just a onSizeChanged modifier to know only when the size changes.

Comments

ma...@google.com <ma...@google.com> #2Apr 15, 2020 03:12PM

First of all thanks for this detailed issue.

This issue had been investigated thoroughly when it was first reported internally. The surprising detail in this report is that the issue is not reproducible before 1.7. I will look into this.

The main problem with POBox is the fact that it is deprecated. Since 2021 Sony has been shipping new Xperia devices with Gboard pre-installed. Although we are aware that there is still a considerable amount of users still using POBox, the described behavior is caused by POBox's noncompliant behavior with InputConnection and InputMethodManager documentation. However, this is understandable since TextView implementation was also not respecting the behavior that is expected from Editors.

Ultimately we have decided to enforce the documented behavior with specifically regards to when editors should call InputMethodManager.updateSelection. Also, although unconfirmed, there were traces of possible custom code being included in Sony OEM images that changed how InputMethodManager was notified from TextView. If POBox also depended on something like this, it would be impossible for Compose code to replicate the same unknown behavior.

ch...@google.com <ch...@google.com> #3Apr 15, 2020 03:17PM

If the investigation takes time, would it be possible to revert the surrounding implementation to 1.6.x equivalent?

Or is that option not available?

Even if the root cause is POBox, from the perspective of the app's customers, it looks like an app bug, so this issue is a blocker against updating Jetpack Compose.

ma...@google.com <ma...@google.com> #4Apr 15, 2020 03:24PM

Reassigned to mo...@google.com.

Just to be sure, it is dangerous to replace Compose TextField with Android View EditText as a workaround for this issue.

Compose 1.7 has a bug that causes ANR when the focus is on EditText. https://issuetracker.google.com/issues/369354336

Another View-related bug in Compose 1.7 is that an Android View is focused by calling FocusManager.clearFocus(). https://issuetracker.google.com/issues/374031296

Perhaps there is a lack of testing of Compose 1.7 in combination with Android View. There is also a possibility that there are other fatal bugs related to View.

In other words, the only options for apps targeting the Japanese market that require POBox support are to continue using Compose 1.6 or to use EditText in combination with various workarounds.

mo...@google.com <mo...@google.com> #5Apr 15, 2020 06:01PM

Reassigned to ch...@google.com.

Project: platform/frameworks/support
Branch: androidx-main
Author: Halil Ozercan <halilibo@google.com>
Link: https://android-review.googlesource.com/3317256

Fix POBox keyboard issue

Expand for full commit details

Fix POBox keyboard issue 
 
Fix: 373743376 
Fix: 329209241 
Test: NullableInputConnectionWrapperTest 
Change-Id: I94e0e598274fb88b255f977f9fbd50dfbbb1ecb1

Files:

M compose/ui/ui/src/androidInstrumentedTest/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapperTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/text/input/NullableInputConnectionWrapper.android.kt

Hash: 57f58c4b80d5d8470b2aca325dfdcd55f235231e
Date: Thu Oct 24 01:25:20 2024

ch...@google.com <ch...@google.com> #6Apr 16, 2020 08:09AM

Reassigned to mo...@google.com.

Many thanks again for this report. Especially for giving us a huge clue in terms of what could be going wrong. The fix is now merged and I will ask for a cherry-pick into a stable release.

ch...@google.com <ch...@google.com> #7Apr 16, 2020 12:44PM

Thank you for fixing the issue, I confirmed the fix was released in version 1.8.0-alpha05.
Do you have any concrete plan to cherry-pick the fix into current stable version (1.7.x)? We are currently waiting it.

mo...@google.com <mo...@google.com> Jul 13, 2020 09:47PM

Accepted by mo...@google.com.

mo...@google.com <mo...@google.com> #8Sep 1, 2020 11:12PM

Yes, this fix is planned to be included in a future 1.7.x release.

ch...@google.com <ch...@google.com> #9Sep 14, 2020 10:19AM

Thanks for the fix. Sorry to follow up on this. is it possible for you to share specific release version/date for the stable version? We are waiting on this to decide on our direction.

Message last modified on Sep 14, 2020 10:20AM

mo...@google.com <mo...@google.com> #10Sep 21, 2020 10:05PM

Nice! I've put in a simplified version of that.

ap...@google.com <ap...@google.com> #11Sep 22, 2020 10:05PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 9209f5d65524cf83c0860459955bd83c5615a817
Author: George Mount <mount@google.com>
Date: Tue Sep 01 14:55:57 2020

Add onSizeChanged() and OnRemeasuredModifier

Added a new modifier to make it faster to notify only when a
layout's content size changes. This avoids the down-hierarchy
notifications required when using onPositioned.

Relnote: "Added OnRemeasuredModifier and onSizeChanged() to
receive a callback when content layout has been remeasured and
the size has changed, respectively."

Fixes: 154108792
Bug: 162351735

Test: OnSizeChangedTest
Change-Id: I657cf033de811e9279a2b2079933ca0bd89e5e60

M compose/ui/ui/api/current.txt
M compose/ui/ui/api/public_plus_experimental_current.txt
M compose/ui/ui/api/restricted_current.txt
A compose/ui/ui/samples/src/main/java/androidx/compose/ui/samples/OnSizeChangedSamples.kt
M compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/input/pointer/PointerInputEventProcessorTest.kt
A compose/ui/ui/src/androidAndroidTest/kotlin/androidx/compose/ui/layout/OnSizeChangedTest.kt
M compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.kt
A compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/OnRemeasuredModifier.kt
M compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/LayoutNode.kt

https://android-review.googlesource.com/1418715