Fixed
Status Update
No update yet.
Comments
sh...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
sh...@google.com
sh...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
je...@google.com
Yes, this seems like a working solution. I have some doubts if we shouldn't address the way the anchor info is updated or used given a reference child, but at the same time I think that is a rabbit hole we should avoid. So I'm in favor of your solution :)
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit fe867028214a364167c893083065eddcd709e223
Author: Shep Shapard <shepshapard@google.com>
Date: Wed Apr 15 14:02:59 2020
Improve out of bounds anchor.
Bug fixes involve a behavior change where
if all in bounds children are removed from a
LinearLayoutManager, and out of bounds children
are found to become potential anchors, out of bounds
children that are "further down in the scroll direction"
are moved to fill in the RV.
Bug: 154124815
Test: ./gradlew recyclerview:recyclerview:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=androidx.recyclerview.widget.LinearLayoutManagerRemoveShownItemsTest
Change-Id: I63b177d1bedd8016125bc6aa619fb12714797252
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerFindReferenceChildTest.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerFindZeroPxReferenceChildTest.kt
A recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerRemoveShownItemsTest.kt
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/GridLayoutManager.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/LinearLayoutManager.java
M samples/Support7Demos/src/main/AndroidManifest.xml
A samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/RemoveLargeItemsDemo.java
A samples/Support7Demos/src/main/res/layout/remove_large_items_demo.xml
A samples/Support7Demos/src/main/res/layout/remove_large_items_demo_item.xml
https://android-review.googlesource.com/1286717
Branch: androidx-master-dev
commit fe867028214a364167c893083065eddcd709e223
Author: Shep Shapard <shepshapard@google.com>
Date: Wed Apr 15 14:02:59 2020
Improve out of bounds anchor.
Bug fixes involve a behavior change where
if all in bounds children are removed from a
LinearLayoutManager, and out of bounds children
are found to become potential anchors, out of bounds
children that are "further down in the scroll direction"
are moved to fill in the RV.
Bug: 154124815
Test: ./gradlew recyclerview:recyclerview:connectedCheck --info --daemon -Pandroid.testInstrumentationRunnerArguments.class=androidx.recyclerview.widget.LinearLayoutManagerRemoveShownItemsTest
Change-Id: I63b177d1bedd8016125bc6aa619fb12714797252
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerFindReferenceChildTest.kt
M recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerFindZeroPxReferenceChildTest.kt
A recyclerview/recyclerview/src/androidTest/java/androidx/recyclerview/widget/LinearLayoutManagerRemoveShownItemsTest.kt
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/GridLayoutManager.java
M recyclerview/recyclerview/src/main/java/androidx/recyclerview/widget/LinearLayoutManager.java
M samples/Support7Demos/src/main/AndroidManifest.xml
A samples/Support7Demos/src/main/java/com/example/android/supportv7/widget/RemoveLargeItemsDemo.java
A samples/Support7Demos/src/main/res/layout/remove_large_items_demo.xml
A samples/Support7Demos/src/main/res/layout/remove_large_items_demo_item.xml
sh...@google.com
ch...@gmail.com
i think this bug doesn't fix. when i clear the mainAdapter and then update footerAdapter, sometimes it will jump to the bottom
Description
When items are same size as the viewport, and RV is currently laid out such that the viewport shows exactly one complete item, and you remove that item from the dataset, it can't find a reference child that is in the viewport. It defaults to using the first child it found in the hierarchy (
getChild(0)for regular LTR RVs) as the reference child. But then it doesn't seem to use that child's old position as the anchor position, but just places that child at the start of the viewport.That is a problem if you are looking at the last item (item N) and have two extra items laid out before the visible one. You'd expect that if you remove item N, you will look at item N-1 after that. But, it will actually go to item N-2.
I didn't check the behavior if you're not looking at the last item, but that might be affected as well.