Fixed
Status Update
No update yet.
Comments
je...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5b0bebd168fded3237342e7aa9e7f039c5182dd2
Author: Filip Pavlis <pavlis@google.com>
Date: Mon Nov 09 18:01:52 2020
Removed dependency on specific activity rule
This removes dependency on ActivityScenarioRule from
AndroidComposeTestRule. Meaning that compose test rule can be used with
any lauchner from now on.
Test: N/A
Bug: 153623653
Bug: 154135019
Relnote: "AndroidComposeTestRule can now accept custom activity
launchers"
Change-Id: Ib828876d918f3f091b622bbeb62dd1a31c75badb
M compose/test-utils/src/androidAndroidTest/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunnerTest.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/TestRuleExtensions.kt
M compose/ui/ui-test-junit4/api/current.txt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/api/restricted_current.txt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/AndroidComposeTestRule.kt
D compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/android/AndroidComposeTestRule.kt
https://android-review.googlesource.com/1492916
Branch: androidx-master-dev
commit 5b0bebd168fded3237342e7aa9e7f039c5182dd2
Author: Filip Pavlis <pavlis@google.com>
Date: Mon Nov 09 18:01:52 2020
Removed dependency on specific activity rule
This removes dependency on ActivityScenarioRule from
AndroidComposeTestRule. Meaning that compose test rule can be used with
any lauchner from now on.
Test: N/A
Bug: 153623653
Bug: 154135019
Relnote: "AndroidComposeTestRule can now accept custom activity
launchers"
Change-Id: Ib828876d918f3f091b622bbeb62dd1a31c75badb
M compose/test-utils/src/androidAndroidTest/kotlin/androidx/compose/testutils/AndroidComposeTestCaseRunnerTest.kt
M compose/test-utils/src/androidMain/kotlin/androidx/compose/testutils/TestRuleExtensions.kt
M compose/ui/ui-test-junit4/api/current.txt
M compose/ui/ui-test-junit4/api/public_plus_experimental_current.txt
M compose/ui/ui-test-junit4/api/restricted_current.txt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/compose/ui/test/junit4/AndroidComposeTestRule.kt
M compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/AndroidComposeTestRule.kt
D compose/ui/ui-test-junit4/src/androidMain/kotlin/androidx/ui/test/android/AndroidComposeTestRule.kt
Description
Sincehttps://r.android.com/1282381 it is mandatory to use ComposeTestRule. This can be a problem for teams that have a custom way with which they launch their app's Activity, since they are now forced to use an ActivityTestRule that they supply to AndroidComposeTestRule.
It should also be possible to use ActivityScenario. The fix for this feature request should not be to add another overload to AndroidComposeTestRule that accepts an ActivityScenario, but to let AndroidComposeTestRule work together with any kind of Activity launcher.
For context, see @pavlis's comment in