IllegalStateException: Image is already closed [154155377]

Fixed

Bug

Status Update

No update yet.

Description

hu...@gmail.com

created issue #1

Apr 16, 2020 09:28AM

CAMERAX VERSION: 1.0.0-beta03

CAMERA APPLICATION NAME AND VERSION: Newly built app not publically available

ANDROID OS BUILD NUMBER: TB-X104F_S100045_200103_ROW

DEVICE NAME: Lenevo E10

DESCRIPTION:

On occasion, on pausing an activity, I notice the following message:

E/AndroidRuntime: FATAL EXCEPTION: pool-1-thread-1
    Process: com.enware.hwdgd, PID: 17160
    java.lang.IllegalStateException: Image is already closed
        at android.media.Image.throwISEIfImageIsInvalid(Image.java:68)
        at android.media.ImageReader$SurfaceImage.getWidth(ImageReader.java:843)
        at androidx.camera.core.AndroidImageProxy.getWidth(AndroidImageProxy.java:88)
        at androidx.camera.core.ForwardingImageProxy.getWidth(ForwardingImageProxy.java:85)
        at androidx.camera.core.ForwardingImageProxy.getWidth(ForwardingImageProxy.java:85)
        at androidx.camera.core.SettableImageProxy.<init>(SettableImageProxy.java:57)
        at androidx.camera.core.SettableImageProxy.<init>(SettableImageProxy.java:44)
        at androidx.camera.core.ImageAnalysisAbstractAnalyzer.lambda$analyzeImage$0$ImageAnalysisAbstractAnalyzer(ImageAnalysisAbstractAnalyzer.java:87)
        at androidx.camera.core.-$$Lambda$ImageAnalysisAbstractAnalyzer$V6Gtux2-h8spda8vf4wFnIZntYI.run(Unknown Source:8)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
        at java.lang.Thread.run(Thread.java:764)

I'm using the image analysis use case which is initialised for the very first onResume like so:

if (cameraExecutor == null) {
    val executor = Executors.newSingleThreadExecutor()
    cameraExecutor = executor

    val processCameraProvider = ProcessCameraProvider.getInstance(this)
    processCameraProvider.addListener(Runnable {
        val cameraProvider = processCameraProvider.get()

        val imageAnalysis = ImageAnalysis.Builder()
            .setBackpressureStrategy(ImageAnalysis.STRATEGY_KEEP_ONLY_LATEST)
            .setTargetResolution(Size(FACE_DETECTOR_WIDTH, FACE_DETECTOR_HEIGHT))
            .build()
...

Within the analyser, I'm calling the Firebase ML Face Detector.

LIST ANY EXPERIMENTAL FEATURES: None known.

STEPS TO REPRODUCE: Cannot share this code, and unfortunately hard to reproduce. The problem is intermittent.

OBSERVED RESULTS: Seeing CameraX report a IllegalStateException

EXPECTED RESULTS: Would expect CameraX to cater for this situation.

REPRODUCIBILITY: (5 of 5, 1 of 100, etc) 1 of 10

ADDITIONAL INFORMATION: None.

CODE FRAGMENTS (this will help us troubleshoot your issues): Hopefully, there's enough.

Comments

ni...@google.com <ni...@google.com> #2Apr 16, 2020 09:47PM

Looks like this is the same as an existing internally tracked issue (b/145956416) where the ImageReader is immediately closed when CameraX is done with it, but does not wait for outstanding Images to be closed (for example given out by ImageCapture or ImageAnalysis).

er...@google.com <er...@google.com> #3Apr 16, 2020 11:19PM

Status: Duplicate of

145956416

I've made Issue 145956416 public so I'll duplicate this issue there. Thanks!

hu...@gmail.com <hu...@gmail.com> #4Apr 16, 2020 11:38PM

Thanks - it is an important issue to me, that is causing a poor user experience.

hu...@gmail.com <hu...@gmail.com> #5Apr 24, 2020 03:15AM

Hi there - is there anything I can do to speed up the repair of this issue? (paid support etc)

er...@google.com <er...@google.com> #6Apr 28, 2020 12:04AM

Hi there,

This has been duplicated to issue tracker item 145956416 (also externally accessible), however CameraX does not have any paid support as we are an open source product - our team is looking into the issue and you can find updated on the duplicate issue. Thanks

fu...@google.com <fu...@google.com> #7Apr 29, 2020 06:44PM

Hi,
Its possible to work around this issue by catching the exception when accessing the ImageProxy in the app's analysis method. When the exception occurs, the app can consider that image as no longer valid.

hu...@gmail.com <hu...@gmail.com> #8May 4, 2020 02:10AM

Its possible to work around this issue by catching the exception when accessing the ImageProxy in the app's analysis method. When the exception occurs, the app can consider that image as no longer valid.

Thanks for responding. Please note the stacktrace - my app isn't in it. However, perhaps I could create a custom Executor and catch there?

ni...@google.com <ni...@google.com> #9May 5, 2020 12:31AM

It looks like you could probably use setBackgroundExecutor() and catch the exception there as a workaround before we get the fix in.

ap...@google.com <ap...@google.com> #10May 15, 2020 01:53AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e8c0fe0ed7331933c1277535245d9de33c2303c1
Author: Franklin Wu <nilknarfuw@google.com>
Date: Tue May 12 15:29:25 2020

Fixed issue where ImageProxyReader in ImageAnalysis is closed prematurely

Added the SafeCloseImageReaderProxy which provides a method to wait
until all acquired ImageProxy are closed before finally closing the
underlying ImageReaderProxy.

Switched ImageAnalysis to use SafeCloseImageReaderProxy and also cleaned
up ImageAnalysis to using lambdas.

Relnote: "Fixes crash in ImageAnalysis where the ImageProxy is accessed
after the ImageReaderProxy has been closed. This also makes it so that
all ImageProxy received by the Analyzer must be closed before the
ImageReaderProxy will be closed."

Bug:

b/145956416

b/154155377

b/156357269

Test: androidx.camera.camera2.ImageAnalysisTest
androidx.camera.core.ImageAnalysisTest

Change-Id: I4b29996bcaf7549df6ababf080ea367326ba0dd3

A camera/camera-core/src/androidTest/java/androidx/camera/core/SafeCloseImageReaderProxyTest.java
M camera/camera-core/src/main/java/androidx/camera/core/ImageAnalysis.java
A camera/camera-core/src/main/java/androidx/camera/core/SafeCloseImageReaderProxy.java
M camera/camera-testing/src/main/java/androidx/camera/testing/fakes/FakeImageReaderProxy.java

https://android-review.googlesource.com/1309661

ni...@google.com <ni...@google.com> #11May 15, 2020 01:59AM

Marked as fixed.

Marking this as fixed, because the duped bug is actually a super set of the this one. The change that fixes this particular issue has been merged. Will be in the 1.0.0-beta04 release.

hu...@gmail.com <hu...@gmail.com> #12Jun 4, 2020 03:41AM

Confirming this as fixed having been applied to my builds and tested.

hu...@gmail.com <hu...@gmail.com> #13Jun 4, 2020 03:41AM

Thanks also for attending to it!

qu...@gmail.com <qu...@gmail.com> #14Nov 12, 2023 05:32PM

Absolutely loved this post! The image resonated with me, reminiscent of the captivating visuals at

https://depositphotos.com/photos/drug-interaction.html. The depth and emotions captured in this post are truly captivating. Kudos to the creator!