Add manifest merger support for action and mimeType in navigation XML [154166825]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Apr 16, 2020 12:44AM

Navigation recently added support for providing intent actions and mimeTypes to nav deep links.

The manifest merger does not currently have the logic needed to consider these fields when generating the intent filters. That logic should be added.

If the custom action in the navigation xml is not an empty string, its value should replace the default android.intent.action.VIEW in the intent filter's <action android:name> element. If the action is an empty string, the <action android:name> element should be removed.

If the navigation xml is provided with a mimeType, its value should be added to the intent filter in an <data android:mimeType> element.

Here are some basic examples:

The deep link is given a custom intent action in the navigation xml:

<deepLink app:action=”android.intent.action.MY_ACTION”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.MY_ACTION" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
</intent-filter>

The deep link is given a mimeType in the navigation xml:

<deepLink app:mimeType=”image/jpg”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.VIEW" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
  <data android:mimeType=”image/jpg” />
</intent-filter>

To see more details and examples, take a look at the design doc.

Comments

vi...@google.com <vi...@google.com> Apr 16, 2020 04:25AM

Reassigned to an...@google.com.

jb...@google.com <jb...@google.com> May 15, 2020 08:30PM

Reassigned to sp...@google.com.

lc...@gmail.com <lc...@gmail.com> #2Jul 12, 2021 02:50PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

lc...@gmail.com <lc...@gmail.com> #3Nov 11, 2021 07:27AM

is there any updates on this issue? i am using Navigation 2.4.0-beta01 and i still do not see the my intent action specified in my navgraph appearing in the merge manifest viewer.

e.g.

<deepLink
    android:autoVerify="true"
    app:action="android.nfc.action.NDEF_DISCOVERED"
    app:uri="https://myapp.app.com/deeplink" 
/>

<deepLink
    app:action="android.nfc.action.NDEF_DISCOVERED"
    app:uri="myapp://myapp.app.com/deeplink" 
/>

but in the merged manifest i do not see android.nfc.action.NDEF_DISCOVERED in the intent filter.I only see action android.intent.action.VIEW.

cl...@gmail.com <cl...@gmail.com> #4Mar 29, 2022 09:19PM

Still not fixed in version 2.4.1

il...@google.com <il...@google.com> #5Mar 29, 2022 09:22PM

What version of Navigation you use doesn't matter here, since it isn't Navigation that is generating intent filters - this needs to be changed in the Android Gradle Plugin side as that is what it generating these intent filters from your Navigation XML files.

an...@gmail.com <an...@gmail.com> #6Mar 29, 2022 10:33PM

The workaround is to manually add intent filter to manifest.

lc...@gmail.com <lc...@gmail.com> #7Nov 1, 2022 07:12AM

Any updates on this? I am still manually adding intent filters to my manifests for my own actions like ndef etc.

sp...@google.com <sp...@google.com> Nov 1, 2022 04:22PM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> Nov 16, 2022 06:28PM

Accepted by mi...@google.com.

mi...@google.com <mi...@google.com> #8Dec 5, 2022 11:26PM

Marked as fixed.

Completed work for adding manifest merged support for action and mimeType. It should be available in the next version of AGP.