Fixed
Status Update
Comments
vi...@google.com <vi...@google.com>
jb...@google.com <jb...@google.com>
lc...@gmail.com <lc...@gmail.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
lc...@gmail.com <lc...@gmail.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
cl...@gmail.com <cl...@gmail.com> #4
deleted
il...@google.com <il...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
an...@gmail.com <an...@gmail.com> #6
The workaround is to manually add intent filter to manifest.
lc...@gmail.com <lc...@gmail.com> #7
Any updates on this? I am still manually adding intent filters to my manifests for my own actions like ndef etc.
sp...@google.com <sp...@google.com>
mi...@google.com <mi...@google.com>
mi...@google.com <mi...@google.com> #8
Completed work for adding manifest merged support for action and mimeType. It should be available in the next version of AGP.
Description
Navigation recently added support for providing intent actions and mimeTypes to nav deep links.
The manifest merger does not currently have the logic needed to consider these fields when generating the intent filters. That logic should be added.
If the custom action in the navigation xml is not an empty string, its value should replace the default
android.intent.action.VIEW
in the intent filter's<action android:name>
element. If the action is an empty string, the<action android:name>
element should be removed.If the navigation xml is provided with a mimeType, its value should be added to the intent filter in an
<data android:mimeType>
element.Here are some basic examples:
The deep link is given a custom intent action in the navigation xml:
<deepLink app:action=”android.intent.action.MY_ACTION”/>
It should be converted to the following intent filter:
The deep link is given a mimeType in the navigation xml:
<deepLink app:mimeType=”image/jpg”/>
It should be converted to the following intent filter:
To see more details and examples, take a look at the design doc .