Fixed
Status Update
Comments
vi...@google.com <vi...@google.com>
jb...@google.com <jb...@google.com>
lc...@gmail.com <lc...@gmail.com> #2
since these are in public API (:/) we need to do this in 1.2
lc...@gmail.com <lc...@gmail.com> #3
since it is already marked as deprecated, we can probably do it by now.
cl...@gmail.com <cl...@gmail.com> #4
Opening diff shortly
il...@google.com <il...@google.com> #5
Project: platform/frameworks/support
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request fromhttps://github.com/androidx/androidx/pull/61 .
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
https://android-review.googlesource.com/1396827
Branch: androidx-master-dev
commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020
[GH] Hide deprecated internal API.
## Proposed Changes
* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.
## Testing
Test: Ran unit tests locally
## Issues Fixed
Fixes: 76109329
This is an imported pull request from
Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7
Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92
A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java
an...@gmail.com <an...@gmail.com> #6
The workaround is to manually add intent filter to manifest.
lc...@gmail.com <lc...@gmail.com> #7
Any updates on this? I am still manually adding intent filters to my manifests for my own actions like ndef etc.
sp...@google.com <sp...@google.com>
mi...@google.com <mi...@google.com>
mi...@google.com <mi...@google.com> #8
Completed work for adding manifest merged support for action and mimeType. It should be available in the next version of AGP.
Description
Navigation recently added support for providing intent actions and mimeTypes to nav deep links.
The manifest merger does not currently have the logic needed to consider these fields when generating the intent filters. That logic should be added.
If the custom action in the navigation xml is not an empty string, its value should replace the default
android.intent.action.VIEW
in the intent filter's<action android:name>
element. If the action is an empty string, the<action android:name>
element should be removed.If the navigation xml is provided with a mimeType, its value should be added to the intent filter in an
<data android:mimeType>
element.Here are some basic examples:
The deep link is given a custom intent action in the navigation xml:
<deepLink app:action=”android.intent.action.MY_ACTION”/>
It should be converted to the following intent filter:
The deep link is given a mimeType in the navigation xml:
<deepLink app:mimeType=”image/jpg”/>
It should be converted to the following intent filter:
To see more details and examples, take a look at the design doc .