Add manifest merger support for action and mimeType in navigation XML [154166825]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Apr 16, 2020 12:44AM

Navigation recently added support for providing intent actions and mimeTypes to nav deep links.

The manifest merger does not currently have the logic needed to consider these fields when generating the intent filters. That logic should be added.

If the custom action in the navigation xml is not an empty string, its value should replace the default android.intent.action.VIEW in the intent filter's <action android:name> element. If the action is an empty string, the <action android:name> element should be removed.

If the navigation xml is provided with a mimeType, its value should be added to the intent filter in an <data android:mimeType> element.

Here are some basic examples:

The deep link is given a custom intent action in the navigation xml:

<deepLink app:action=”android.intent.action.MY_ACTION”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.MY_ACTION" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
</intent-filter>

The deep link is given a mimeType in the navigation xml:

<deepLink app:mimeType=”image/jpg”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.VIEW" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
  <data android:mimeType=”image/jpg” />
</intent-filter>

To see more details and examples, take a look at the design doc.

Comments

vi...@google.com <vi...@google.com> Apr 16, 2020 04:25AM

Reassigned to an...@google.com.

jb...@google.com <jb...@google.com> May 15, 2020 08:30PM

Reassigned to sp...@google.com.

lc...@gmail.com <lc...@gmail.com> #2Jul 12, 2021 02:50PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

lc...@gmail.com <lc...@gmail.com> #3Nov 11, 2021 07:27AM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

cl...@gmail.com <cl...@gmail.com> #4Mar 29, 2022 09:19PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020

Re-factor how errors are dismissed when query is re-written

This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (

b/140759491

).
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.

This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.

Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f

M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt

https://android-review.googlesource.com/1288456

il...@google.com <il...@google.com> #5Mar 29, 2022 09:22PM

What version of Navigation you use doesn't matter here, since it isn't Navigation that is generating intent filters - this needs to be changed in the Android Gradle Plugin side as that is what it generating these intent filters from your Navigation XML files.

an...@gmail.com <an...@gmail.com> #6Mar 29, 2022 10:33PM

The workaround is to manually add intent filter to manifest.

lc...@gmail.com <lc...@gmail.com> #7Nov 1, 2022 07:12AM

Any updates on this? I am still manually adding intent filters to my manifests for my own actions like ndef etc.

sp...@google.com <sp...@google.com> Nov 1, 2022 04:22PM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> Nov 16, 2022 06:28PM

Accepted by mi...@google.com.

mi...@google.com <mi...@google.com> #8Dec 5, 2022 11:26PM

Marked as fixed.

Completed work for adding manifest merged support for action and mimeType. It should be available in the next version of AGP.