Add manifest merger support for action and mimeType in navigation XML [154166825]

Fixed

Bug

Status Update

No update yet.

Description

jb...@google.com

created issue #1

Apr 16, 2020 12:44AM

Navigation recently added support for providing intent actions and mimeTypes to nav deep links.

The manifest merger does not currently have the logic needed to consider these fields when generating the intent filters. That logic should be added.

If the custom action in the navigation xml is not an empty string, its value should replace the default android.intent.action.VIEW in the intent filter's <action android:name> element. If the action is an empty string, the <action android:name> element should be removed.

If the navigation xml is provided with a mimeType, its value should be added to the intent filter in an <data android:mimeType> element.

Here are some basic examples:

The deep link is given a custom intent action in the navigation xml:

<deepLink app:action=”android.intent.action.MY_ACTION”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.MY_ACTION" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
</intent-filter>

The deep link is given a mimeType in the navigation xml:

<deepLink app:mimeType=”image/jpg”/>

It should be converted to the following intent filter:

<intent-filter>
  <action android:name="android.intent.action.VIEW" />
  <category android:name="android.intent.category.DEFAULT" />
  <category android:name="android.intent.category.BROWSABLE" />
  <data android:mimeType=”image/jpg” />
</intent-filter>

To see more details and examples, take a look at the design doc.

Comments

vi...@google.com <vi...@google.com> Apr 16, 2020 04:25AM

Reassigned to an...@google.com.

jb...@google.com <jb...@google.com> May 15, 2020 08:30PM

Reassigned to sp...@google.com.

lc...@gmail.com <lc...@gmail.com> #2Jul 12, 2021 02:50PM

A couple of questions:

1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?

lc...@gmail.com <lc...@gmail.com> #3Nov 11, 2021 07:27AM

Tested on Android 12 Emulator with custom executor, but cannot repro this issue.

cl...@gmail.com <cl...@gmail.com> #4Mar 29, 2022 09:19PM

Second crash in the description is from a real device. Experienced it myself on two different Xiaomi phones, plus lots of crashes from users in the Google Play console.
Dynamic features are not used in the application.

As a wild guess, I have downgraded build tools from 31.0.0 to 30.0.3, compileSdk from 31 to 30, and moved all work with Language ID to the service in a separate process (just to be sure that crash can kill secondary process instead of main). This combination is in beta for 2 days by now and I don't see any SIGSEGV crashes.

il...@google.com <il...@google.com> #5Mar 29, 2022 09:22PM

Hmm, I feel the crash might be something related to separate/secondary process.

I also changed compileSdk and targetSDK to 31 but still cannot repro this issue.

an...@gmail.com <an...@gmail.com> #6Mar 29, 2022 10:33PM

On the contrary, there was no separate process before, when crashes started.

In the new build (with the aforementioned changes) I can see SIGSEGV crash, but only one instead of dozens and it has a bit different backtrace:

signal 11 (SIGSEGV), code 1 (SEGV_MAPERR)
liblanguage_id_jni.so (offset 0x11e000)

backtrace:
  #00  pc 000000000003c7c0  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003b960  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bb48  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 000000000003bafc  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000036c98  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000032714  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000031cac  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/split_config.arm64_v8a.apk!lib/arm64-v8a/liblanguage_id_jni.so (offset 0x11e000)
  #00  pc 0000000000057438  /data/app/azagroup.reedy-mF7zTu2bv_ELlbFArwNgqA==/oat/arm64/base.odex (offset 0x57000)

lc...@gmail.com <lc...@gmail.com> #7Nov 1, 2022 07:12AM

FYI, ML Kit launched a new language ID SDK in the latest release, which uses a new language ID model. https://developers.google.com/ml-kit/release-notes#august_11_2021

Could you try the new SDK version(17.0.0) to check if you can still repro this native crash? Thanks!

sp...@google.com <sp...@google.com> Nov 1, 2022 04:22PM

Reassigned to mi...@google.com.

mi...@google.com <mi...@google.com> Nov 16, 2022 06:28PM

Accepted by mi...@google.com.

mi...@google.com <mi...@google.com> #8Dec 5, 2022 11:26PM

Marked as fixed.

Thank you, I'll try it and check.