Assigned
Status Update
Comments
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit ddafb3e1713fb8129dcbb25ee603446ea73d29ef
Author: Chris Craik <ccraik@google.com>
Date: Fri Nov 11 16:45:08 2022
Workaround irrelevant stderr when moving perfetto config
Test: PerfettoTraceRuleTest # Nexus 6 API 23
Bug: 258863685
Change-Id: I45731541c296f65db45d12173f6640c81d8ac65f
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt
https://android-review.googlesource.com/2301081
Branch: androidx-main
commit ddafb3e1713fb8129dcbb25ee603446ea73d29ef
Author: Chris Craik <ccraik@google.com>
Date: Fri Nov 11 16:45:08 2022
Workaround irrelevant stderr when moving perfetto config
Test: PerfettoTraceRuleTest # Nexus 6 API 23
Bug: 258863685
Change-Id: I45731541c296f65db45d12173f6640c81d8ac65f
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt
cc...@google.com <cc...@google.com> #3
After more investigation, the actual issue here is that on userdebug devices i had a stale copy of perfetto_trace_processor stored by a rooted session. Later, when running without root, the copy command (which can't be easily checked for stderr due to its use in super early setup stages) can silently fail, but everything keeps running since the perfetto api is stable.
Actual fix - validate the copy command (without using stderr, since we can't safely).
cc...@google.com <cc...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 9f3bdddc765d2bd2f36c722149a1438da4948b06
Author: Chris Craik <ccraik@google.com>
Date: Fri Nov 11 16:59:28 2022
Validate executables before running, fix other API 22/23 breakages
Test: Tests in benchmark-common/macro, shamu API 23 # several preexisting failures
Test: Tests in benchmark-common/junit4, shamu API 22 # several preexisting failures
Fixes: 258863685
Relnote:"Fix several shell command failures on API <=23, including
failed perfetto capture binary setup and trace capture failures"
Also fixes xargs tests to expect 23+, which is where it was actually
first introduced, and several tests broken by shell safety not caught
by presubmit.
Change-Id: Ib6b872bca51c04c69a454dc1d896d3d7200abcc0
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellBehaviorTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/UiState.kt
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ProfileInstallBroadcastTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
https://android-review.googlesource.com/2301082
Branch: androidx-main
commit 9f3bdddc765d2bd2f36c722149a1438da4948b06
Author: Chris Craik <ccraik@google.com>
Date: Fri Nov 11 16:59:28 2022
Validate executables before running, fix other API 22/23 breakages
Test: Tests in benchmark-common/macro, shamu API 23 # several preexisting failures
Test: Tests in benchmark-common/junit4, shamu API 22 # several preexisting failures
Fixes: 258863685
Relnote:"Fix several shell command failures on API <=23, including
failed perfetto capture binary setup and trace capture failures"
Also fixes xargs tests to expect 23+, which is where it was actually
first introduced, and several tests broken by shell safety not caught
by presubmit.
Change-Id: Ib6b872bca51c04c69a454dc1d896d3d7200abcc0
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellBehaviorTest.kt
M benchmark/benchmark-common/src/androidTest/java/androidx/benchmark/ShellTest.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/Shell.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/UiState.kt
M benchmark/benchmark-junit4/src/main/java/androidx/benchmark/junit4/BenchmarkRule.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/ProfileInstallBroadcastTest.kt
M benchmark/benchmark-macro/src/androidTest/java/androidx/benchmark/macro/perfetto/StartupTimingQueryTest.kt
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.2.0-alpha08
androidx.benchmark:benchmark-junit4:1.2.0-alpha08
androidx.benchmark:benchmark-macro:1.2.0-alpha08
cc...@google.com <cc...@google.com> #6
With the above CL, we've moved to sendStatus(2, bundle).
We can move to addResults (on supported platform versions) once we use our own JSON for uploading to Skia.
ap...@google.com <ap...@google.com> #7
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6b8eee4a0ff1cd0bd197aa36329da7e19e605e27
Author: Chris Craik <ccraik@google.com>
Date: Tue Jun 02 12:54:25 2020
Fix additional invalid instrumentation status error
Bug: 154248456
Test: ./gradlew benchmark:b-b:cC (no longer prints error)
Test: TrivialKotlinBenchmark (from Studio, console output still works)
Change-Id: I80fd74f30af6afb84435f818ea6d598696c3f342
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
https://android-review.googlesource.com/1321947
Branch: androidx-master-dev
commit 6b8eee4a0ff1cd0bd197aa36329da7e19e605e27
Author: Chris Craik <ccraik@google.com>
Date: Tue Jun 02 12:54:25 2020
Fix additional invalid instrumentation status error
Bug: 154248456
Test: ./gradlew benchmark:b-b:cC (no longer prints error)
Test: TrivialKotlinBenchmark (from Studio, console output still works)
Change-Id: I80fd74f30af6afb84435f818ea6d598696c3f342
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
Description
Using addResults should fix the following CLI warning that's started showing up from AGP in recent versions, once per test:
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result