Move to Instrumentation.addResults() [154248456]

Assigned

Bug

Status Update

No update yet.

Description

cc...@google.com

created issue #1

Apr 16, 2020 07:33PM

Currently we use Instrumentation.sendStatus() to report our internal metrics and studio output.

Using addResults should fix the following CLI warning that's started showing up from AGP in recent versions, once per test:

[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result

Comments

ap...@google.com <ap...@google.com> #2Apr 20, 2020 07:45PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 5f42f07ec2b8acf74af422829d8e95d775107af0
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Oct 13 17:48:56 2021

Add a `measureRepeated` overload for `MacrobenchmarkRule`

* Uses a `Consumer<MacrobenchmarkScope>` which makes things easier for Java developers.

Test: Updated unit test.
Bug:

b/184546459

Relnote: Uses a `Consumer<MacrobenchmarkScope>` functional interface, that makes it easy for Java developers to author Macrobenchmarks.
Change-Id: If74abe75c4b0defd0016acd3de20689cf604badd

M benchmark/benchmark-macro-junit4/build.gradle
M benchmark/benchmark-macro-junit4/api/restricted_1.1.0-beta01.txt
M benchmark/benchmark-macro-junit4/src/main/java/androidx/benchmark/macro/junit4/MacrobenchmarkRule.kt
M benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/TrivialStartupJavaBenchmark.java
M benchmark/benchmark-macro-junit4/api/current.txt
M benchmark/benchmark-macro-junit4/api/restricted_current.txt
M benchmark/benchmark-macro-junit4/api/public_plus_experimental_1.1.0-beta01.txt
M benchmark/benchmark-macro-junit4/api/1.1.0-beta01.txt
M benchmark/benchmark-macro-junit4/api/public_plus_experimental_current.txt

https://android-review.googlesource.com/1856865

cc...@google.com <cc...@google.com> #3Apr 27, 2020 07:29PM

Status: Assigned (reopened)

Project: platform/frameworks/support
Branch: androidx-main

commit 93b34a82a8608e02f25b02e85c43b0a59f4babda
Author: Rahul Ravikumar <rahulrav@google.com>
Date: Wed Oct 13 16:21:53 2021

Better Java APIs for Macrobenchmarks.

* Add @JvmOverloads for default paramters.

Bug:

b/184546459

Test: Added a `TrivialStartupJavaBenchmark`
Change-Id: I644fe5b1ba90200ae264e8dabd68ae27689befa8
Relnote: Better Java APIs for Macrobenchmarks.

M benchmark/benchmark-macro/src/main/java/androidx/benchmark/macro/MacrobenchmarkScope.kt
M benchmark/benchmark-macro/api/current.txt
M benchmark/benchmark-macro/api/restricted_1.1.0-beta01.txt
A benchmark/integration-tests/macrobenchmark/src/androidTest/java/androidx/benchmark/integration/macrobenchmark/TrivialStartupJavaBenchmark.java
M benchmark/benchmark-macro/api/public_plus_experimental_1.1.0-beta01.txt
M benchmark/benchmark-macro/api/1.1.0-beta01.txt
M benchmark/benchmark-macro/api/public_plus_experimental_current.txt
M benchmark/benchmark-macro/api/restricted_current.txt

https://android-review.googlesource.com/1856860

cc...@google.com <cc...@google.com> #4Apr 27, 2020 07:30PM

Revert:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1294258

ap...@google.com <ap...@google.com> #5May 26, 2020 10:45PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 24c62381d769dcf170aadec9d6c663a3acc5bb46
Author: Chris Craik <ccraik@google.com>
Date: Tue May 26 10:21:50 2020

Fix invalid instrumentation status bundle error

Test: ./gradlew benchmark:b-b:cC
Test: TrivialKotlinBenchmark (from Studio)
Bug: 154248456
Relnote: "Fixed InstrumentationResultParser error printed for each
benchmark when running from command line."

With this change, no longer see outputs like the following from gradle benchmark runs:

[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result

Manually verified studio output as well.

Change-Id: I64988447a89d7e0314cedabf87812eaf6c413545

M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt

https://android-review.googlesource.com/1317995

cc...@google.com <cc...@google.com> #6May 26, 2020 10:45PM

With the above CL, we've moved to sendStatus(2, bundle).

We can move to addResults (on supported platform versions) once we use our own JSON for uploading to Skia.

ap...@google.com <ap...@google.com> #7Jun 3, 2020 03:31PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 6b8eee4a0ff1cd0bd197aa36329da7e19e605e27
Author: Chris Craik <ccraik@google.com>
Date: Tue Jun 02 12:54:25 2020

Fix additional invalid instrumentation status error

Bug: 154248456
Test: ./gradlew benchmark:b-b:cC (no longer prints error)
Test: TrivialKotlinBenchmark (from Studio, console output still works)

Change-Id: I80fd74f30af6afb84435f818ea6d598696c3f342

M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt

https://android-review.googlesource.com/1321947

Issue 154248456