Assigned
Status Update
No update yet.
Comments
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
cc...@google.com
cc...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 24c62381d769dcf170aadec9d6c663a3acc5bb46
Author: Chris Craik <ccraik@google.com>
Date: Tue May 26 10:21:50 2020
Fix invalid instrumentation status bundle error
Test: ./gradlew benchmark:b-b:cC
Test: TrivialKotlinBenchmark (from Studio)
Bug: 154248456
Relnote: "Fixed InstrumentationResultParser error printed for each
benchmark when running from command line."
With this change, no longer see outputs like the following from gradle benchmark runs:
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
Manually verified studio output as well.
Change-Id: I64988447a89d7e0314cedabf87812eaf6c413545
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
https://android-review.googlesource.com/1317995
Branch: androidx-master-dev
commit 24c62381d769dcf170aadec9d6c663a3acc5bb46
Author: Chris Craik <ccraik@google.com>
Date: Tue May 26 10:21:50 2020
Fix invalid instrumentation status bundle error
Test: ./gradlew benchmark:b-b:cC
Test: TrivialKotlinBenchmark (from Studio)
Bug: 154248456
Relnote: "Fixed InstrumentationResultParser error printed for each
benchmark when running from command line."
With this change, no longer see outputs like the following from gradle benchmark runs:
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
Manually verified studio output as well.
Change-Id: I64988447a89d7e0314cedabf87812eaf6c413545
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
cc...@google.com
With the above CL, we've moved to sendStatus(2, bundle).
We can move to addResults (on supported platform versions) once we use our own JSON for uploading to Skia.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 6b8eee4a0ff1cd0bd197aa36329da7e19e605e27
Author: Chris Craik <ccraik@google.com>
Date: Tue Jun 02 12:54:25 2020
Fix additional invalid instrumentation status error
Bug: 154248456
Test: ./gradlew benchmark:b-b:cC (no longer prints error)
Test: TrivialKotlinBenchmark (from Studio, console output still works)
Change-Id: I80fd74f30af6afb84435f818ea6d598696c3f342
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
https://android-review.googlesource.com/1321947
Branch: androidx-master-dev
commit 6b8eee4a0ff1cd0bd197aa36329da7e19e605e27
Author: Chris Craik <ccraik@google.com>
Date: Tue Jun 02 12:54:25 2020
Fix additional invalid instrumentation status error
Bug: 154248456
Test: ./gradlew benchmark:b-b:cC (no longer prints error)
Test: TrivialKotlinBenchmark (from Studio, console output still works)
Change-Id: I80fd74f30af6afb84435f818ea6d598696c3f342
M benchmark/common/src/main/java/androidx/benchmark/BenchmarkState.kt
Description
Using addResults should fix the following CLI warning that's started showing up from AGP in recent versions, once per test:
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result
[InstrumentationResultParser]: invalid instrumentation status bundle unknown result