Fixed
Status Update
Comments
b9...@gmail.com <b9...@gmail.com> #2
Yigit, do you have time to fix it?
reemission of the same liveData is racy
reemission of the same liveData is racy
je...@google.com <je...@google.com>
b9...@gmail.com <b9...@gmail.com> #4
Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.
al...@gmail.com <al...@gmail.com> #5
just emitting same live data reproduces the issue.
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}
ap...@google.com <ap...@google.com> #6
With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)
al...@gmail.com <al...@gmail.com> #7
yea sorry immediate does not fix it.
I actually have a WIP fix for it:
https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186
if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}
I actually have a WIP fix for it:
if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}
il...@google.com <il...@google.com> #8
Project: platform/frameworks/support
Branch: androidx-master-dev
commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019
Fix coroutine livedata race condition
This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.
We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)
Bug: 140249349
Test: BuildLiveDataTest#raceTest_*
Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40
M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
https://android-review.googlesource.com/1112186
https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06
Branch: androidx-master-dev
commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019
Fix coroutine livedata race condition
This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.
We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)
Bug: 140249349
Test: BuildLiveDataTest#raceTest_*
Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40
M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt
ap...@google.com <ap...@google.com> #9
Project: platform/frameworks/support
Branch: androidx-master-dev
commit 5277ad9de4c6cdc4d5d4a5808644b8e019ce5925
Author: Ian Lake <ilake@google.com>
Date: Fri May 01 11:25:24 2020
Change TakePicture to return a boolean result
The primary use case for using the TakePicture
contract is to save an image to a given Uri
therefore the return type should reflect this
by using a boolean result, avoiding the need
to distinguish between a null result due to
the user cancelling taking a picture and a
null result due to the Camera app not also
returning a thumbnail Bitmap.
Test: updated activity testapp
BUG: 154302879
Change-Id: I46caa5bc865473f083dfd95013cad661296c0029
M activity/activity/api/1.2.0-alpha05.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha05.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha05.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
M activity/integration-tests/testapp/src/main/AndroidManifest.xml
M activity/integration-tests/testapp/src/main/java/androidx/activity/integration/testapp/MainActivity.kt
A activity/integration-tests/testapp/src/main/res/xml/file_paths.xml
https://android-review.googlesource.com/1300254
Branch: androidx-master-dev
commit 5277ad9de4c6cdc4d5d4a5808644b8e019ce5925
Author: Ian Lake <ilake@google.com>
Date: Fri May 01 11:25:24 2020
Change TakePicture to return a boolean result
The primary use case for using the TakePicture
contract is to save an image to a given Uri
therefore the return type should reflect this
by using a boolean result, avoiding the need
to distinguish between a null result due to
the user cancelling taking a picture and a
null result due to the Camera app not also
returning a thumbnail Bitmap.
Test: updated activity testapp
BUG: 154302879
Change-Id: I46caa5bc865473f083dfd95013cad661296c0029
M activity/activity/api/1.2.0-alpha05.txt
M activity/activity/api/current.txt
M activity/activity/api/public_plus_experimental_1.2.0-alpha05.txt
M activity/activity/api/public_plus_experimental_current.txt
M activity/activity/api/restricted_1.2.0-alpha05.txt
M activity/activity/api/restricted_current.txt
M activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java
M activity/integration-tests/testapp/src/main/AndroidManifest.xml
M activity/integration-tests/testapp/src/main/java/androidx/activity/integration/testapp/MainActivity.kt
A activity/integration-tests/testapp/src/main/res/xml/file_paths.xml
il...@google.com <il...@google.com> #10
We've updated the TakePicture
contract to return a boolean indicating success or not. This will be available in Activity 1.2.0-alpha05.
b9...@gmail.com <b9...@gmail.com> #11
Great! Thanks.
al...@gmail.com <al...@gmail.com> #12
Thanks!
Description
I am using the following code to take a picture and upload. During this process, I will need a thumbnail for preview. I am using
androidx.activity:activity-ktx:1.2.0-alpha03
andandroidx.fragment:fragment-ktx:1.3.0-alpha03
, tested on Pixel 2 Xl API 29 on emulator.The code in invoked by a view, which is owned by a fragment(
caller
), which is owned by an activityThe current result is that
ActivityResultContracts.TakePicture()
always return null, but images are correctly saved into the provided uri... I also found out thatintent
doesn't seem to have any extras when it returns.Please let me know if you need any information. Thanks in advanced!