FragmentContainerView within PreferenceDialogFragmentCompat crashes [154366601]

Fixed

Bug

Status Update

No update yet.

Description

th...@outlook.com

created issue #1

Apr 18, 2020 01:12PM

I have a PreferenceScreen with a DialogPreference that opens a PreferenceDialogFragmentCompat when there is being clicked on. The DialogPreference has a custom dialogLayoutResource in which I set a new PreferenceFragmentCompat through xml using the <FragmentContainerView/> tag. On clicking the DialogPreference, the crash posted below occurs.

This crash does not occur when commenting out <FragmentContainerView/>

I was able to workaround this issue by using the following code in PreferenceDialogFragmentCompat:

private lateinit var mView: View

override fun onCreateDialogView(context: Context?): View {
    mView = super.onCreateDialogView(context)
    return mView
}

override fun onCreateView(
    inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?
): View? = mView

A sample project demonstrating the isue can be found here

java.lang.IllegalStateException: Fragment androidx.fragment.app.Fragment$4@d586457 does not have a view
    at androidx.fragment.app.Fragment$4.onFindViewById(Fragment.java:2660)
    at androidx.fragment.app.FragmentAnim.loadAnimation(FragmentAnim.java:56)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1458)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2625)
    at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2577)
    at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2722)
    at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:346)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1188)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1356)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1434)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1497)
    at androidx.fragment.app.BackStackRecord.executeOps(BackStackRecord.java:447)
    at androidx.fragment.app.FragmentManager.executeOps(FragmentManager.java:2169)
    at androidx.fragment.app.FragmentManager.executeOpsTogether(FragmentManager.java:1992)
    at androidx.fragment.app.FragmentManager.removeRedundantOperationsAndExecute(FragmentManager.java:1947)
    at androidx.fragment.app.FragmentManager.execPendingActions(FragmentManager.java:1849)
    at androidx.fragment.app.FragmentManager$4.run(FragmentManager.java:413)
    at android.os.Handler.handleCallback(Handler.java:873)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:193)
    at android.app.ActivityThread.main(ActivityThread.java:6854)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:860)

Comments

ja...@google.com <ja...@google.com> Apr 20, 2020 12:34PM

Status: New

il...@google.com <il...@google.com> #2Apr 20, 2020 04:16PM

Status: Duplicate of

150051716

Please include a sample project that reproduces your issue.

th...@outlook.com <th...@outlook.com> #3Apr 20, 2020 11:06PM

Here is the sample project.

Steps to reproduce:
1. Press on "Search" icon;
2. Write something;
3. Search this text, keyboard will be dismissed;
4. Tap on "Dialog" button;
5. Dissmiss dialog;

With the new 1.5.0 fragment library version text will be cleared in the search box after dismissing dialog.
In the version 1.4.1 and lower text in the search is not clearing and this is correct behaviour.

Please suggest some workarounds or how to fix this issue?

il...@google.com <il...@google.com> Apr 20, 2020 11:18PM

Status: New (reopened)

il...@google.com <il...@google.com> #4Apr 21, 2020 12:23AM

Hello, have you checked sample project? I hope it will help find the issue.

th...@outlook.com <th...@outlook.com> #5Apr 21, 2020 12:53AM

@3
I've described a weird workaround that I got, here:

https://issuetracker.google.com/issues/244854449#comment3
Sample:

https://issuetracker.google.com/issues/244854449#comment4

It probably has bugs of its own that I didn't think of.
Google please fix this.

th...@outlook.com <th...@outlook.com> #6Apr 21, 2020 09:43AM

Hello, any update please?

il...@google.com <il...@google.com> #7Apr 21, 2020 11:49PM

Accepted by il...@google.com.

Hello I raised similar issue with this ticket https://issuetracker.google.com/issues/249247706

This makes the SearchView unusable/broken when fragments are changed (i.e base on searchView input query)

What can we do to fix this problem? What is the progress of work on solving this problem?

ap...@google.com <ap...@google.com> #8Apr 22, 2020 02:40PM

@7 Check @5 for a workaround.

il...@google.com <il...@google.com> #9Apr 23, 2020 12:16AM

Marked as fixed.

Hi, i am also facing this issue after we dismiss a DialogFragment, the callback comes in the onPrepareOptionsMenu(), which is causing the issues for me.
Any idea on when it will be fixed?

th...@outlook.com <th...@outlook.com> #10Apr 23, 2020 12:46AM

Hello, any estimate please?