EncryptedSharedPreferences: edit().clear().apply() doesn't work [154366606]

Fixed

Bug

Status Update

No update yet.

Description

ph...@gmail.com

created issue #1

Apr 18, 2020 02:56PM

I'm using the EncryptedSharedPreferences from androidx.security:security-crypto:1.0.0-rc01 .

I noticed that prefs.edit().clear().apply() does not actually clear the preferences, while prefs.edit().clear().commit() works.

Looking at the code of EncryptedSharedPreferences, I see that in the editor's commit method, mClearRequested is tested, while in the apply method it is not. This is clearly a bug.

Comments

jm...@google.com <jm...@google.com> #2Apr 20, 2020 08:23PM

Hi Ed, Thank you so much for these suggestions. I've been reviewing them and merging them in. Hopefully it should be live. I've included a thank you note too in the article.

ap...@google.com <ap...@google.com> #3May 14, 2020 08:43PM

Great! Thanks a lot, I'll look for the live updates soon!

jm...@google.com <jm...@google.com> #4May 15, 2020 04:37AM

Marked as fixed.

Will be in the next release.

an...@google.com <an...@google.com> #5May 18, 2020 02:47PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/4751834870513664/#/history/all)
Created: 2020-05-18 14:44:21.155034+00:00
Changes: aosp/1312015

ph...@gmail.com <ph...@gmail.com> #6May 19, 2020 10:56AM

Thanks a lot.

Issue 154366606