Status Update
Comments
il...@google.com <il...@google.com> #2
Note that as per the intro_navigation
as the start destination of your graph, but instead following the
We'll take a look nonetheless.
[Deleted User] <[Deleted User]> #3
We're experiencing this in 2.3.0-alpha05. We have a setup like:
- navGraphHome (startDestination = navGraphStart)
- navGraphStart
- navGraphWanted (startDestination = destWanted)
- destWanted (with deeplink)
When handling a deeplink to destWanted
, NavController.findInvalidDestinationDisplayNameInDeepLink
unconditionally traverses to navGraphStart
, which of course does not contain destWanted
and results in the deeplink being ignored.
Conditional navigation isn't desired as these graphs are top-level destinations for a navigation drawer.
il...@google.com <il...@google.com> #4
Yep, this is a regression in Navigation 2.2.2 and 2.3.0-alpha05 when you have a nested start destination.
ap...@google.com <ap...@google.com> #5
Branch: androidx-master-dev
commit 96fc97e0e9f09ed2ea09bfed3610373ba18ef547
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 21 15:05:30 2020
Fix deep linking when using nested start destinations
Ensure that findInvalidDestinationDisplayNameInDeepLink
correctly handles nested start destinations.
Test: new NavControllerTest passes
BUG: 154532067
Change-Id: I95b84ea1ca0f8901c3af5447a3f60fae29daa8d0
M navigation/navigation-runtime/src/androidTest/java/androidx/navigation/NavControllerTest.kt
M navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.java
il...@google.com <il...@google.com> #6
We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05. We're still evaluating a potential 2.2.X release (which would include this release if we did one).
[Deleted User] <[Deleted User]> #7
Thanks!
an...@google.com <an...@google.com> #8
il...@google.com <il...@google.com> #9
dk...@fundrise.com <dk...@fundrise.com> #10
Guys, 2.3.0 doesn't have this fix included
il...@google.com <il...@google.com> #11
Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.
Description
Component used: Navigation
Version used: 2.2.2
Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10
The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:
This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.
The issue here is that in
main_navigation
i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fineScenario to reproduce problem on attached project
Pending intent in notification should point to main page, but it can't. Why? Because method
findInvalidDestinationDisplayNameInDeepLink
is looking for deep link handler twice. Once in propermain_navigation
. But the second time - it is looking for it inintro_navigation
, which doesn't have destination we are looking for. The changed line that broke things isgraph.findNode(destinationId, false);
. And it seems reasonable to me -intro_navigation
can't find proper node, but it's parent can. I can confirm that evaluatinggraph.findNode(destinationId, true);
returns proper node which is expected behavior.Please ask if i can provide you with more information. Full reproduction sample provided.