"Could not find destination in the navigation graph, ignoring the deep link from Intent" for deep link in nested navigation [154532067]

Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Apr 21, 2020 07:20AM

Component used: Navigation

Version used: 2.2.2

Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10

The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:

I/NavController: Could not find destination com.my.app:id/main_navigation in the navigation graph, ignoring the deep link from Intent { act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x1040c000 pkg=com.my.app cmp=com.my.app/com.my.app.MainActivity (has extras) }

This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.

The issue here is that in main_navigation i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fine

Scenario to reproduce problem on attached project

Run app
Click "go to main page"
Click "Create notification"
Now hide the application and click notification

Pending intent in notification should point to main page, but it can't. Why? Because method findInvalidDestinationDisplayNameInDeepLink is looking for deep link handler twice. Once in proper main_navigation. But the second time - it is looking for it in intro_navigation, which doesn't have destination we are looking for. The changed line that broke things is graph.findNode(destinationId, false);. And it seems reasonable to me - intro_navigation can't find proper node, but it's parent can. I can confirm that evaluating graph.findNode(destinationId, true); returns proper node which is expected behavior.

Please ask if i can provide you with more information. Full reproduction sample provided.

TestApplication.zip

148 KB

Download

Comments

il...@google.com <il...@google.com> #2Apr 21, 2020 04:25PM

Yigit, do you have time to fix it?

reemission of the same liveData is racy

[Deleted User] <[Deleted User]> #3Apr 21, 2020 09:39PM

yea i'll take it.

il...@google.com <il...@google.com> #4Apr 21, 2020 10:05PM

Accepted by il...@google.com.

Thanks for the detailed analysis. This may not be an issue anymore since we've started using Main.immediate there but I' not sure; I'll try to create a test case.

ap...@google.com <ap...@google.com> #5Apr 21, 2020 10:59PM

just emitting same live data reproduces the issue.

@Test
fun raceTest() {
val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData)
emitSource(subLiveData) //crashes
}
subject.addObserver().apply {
testScope.advanceUntilIdle()
}
}

il...@google.com <il...@google.com> #6Apr 22, 2020 12:00AM

Marked as fixed.

With 2.2.0-alpha04 (that use Main.immediate), the issue seems to be still there (I tested it by calling emitSource() twice, like your test case)

[Deleted User] <[Deleted User]> #7Apr 23, 2020 05:43PM

yea sorry immediate does not fix it.
I actually have a WIP fix for it:

https://android-review.googlesource.com/c/platform/frameworks/support/+/1112186

if your case is the one i found (emitting same LiveData multiple times, as shown in #5) you can work around it by adding a dummy transformation.

val subLiveData = MutableLiveData(1)
val subject = liveData(testScope.coroutineContext) {
emitSource(subLiveData.map {it })
emitSource(subLiveData.map {it} )
}

an...@google.com <an...@google.com> #8May 26, 2020 09:07PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit af12e75e6b4110f48e44ca121466943909de8f06
Author: Yigit Boyar <yboyar@google.com>
Date: Tue Sep 03 12:58:11 2019

Fix coroutine livedata race condition

This CL fixes a bug in liveData builder where emitting same
LiveData source twice would make it crash because the second
emission registry could possibly happen before first one is
removed as source.

We fix it by using a suspending dispose function. It does feel
a bit hacky but we cannot make DisposableHandle.dispose async
and we do not want to block there. This does not mean that there
is a problem if developer disposes it manually since our emit
functions take care of making sure it disposes (and there is
no other way to add source to the underlying MediatorLiveData)

Bug: 140249349
Test: BuildLiveDataTest#raceTest_*

Change-Id: I0b464c242a583da4669af195cf2504e2adc4de40

M lifecycle/lifecycle-livedata-ktx/api/2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/current.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/public_plus_experimental_current.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_2.2.0-alpha05.txt
M lifecycle/lifecycle-livedata-ktx/api/restricted_current.txt
M lifecycle/lifecycle-livedata-ktx/src/main/java/androidx/lifecycle/CoroutineLiveData.kt
M lifecycle/lifecycle-livedata-ktx/src/test/java/androidx/lifecycle/BuildLiveDataTest.kt

https://android-review.googlesource.com/1112186

https://goto.google.com/android-sha1/af12e75e6b4110f48e44ca121466943909de8f06

il...@google.com <il...@google.com> #9May 27, 2020 05:37PM

We've decided to release a Navigation 2.2.3 bug fix release and will be including this change in that release.

dk...@fundrise.com <dk...@fundrise.com> #10Aug 18, 2020 08:39PM

Guys, 2.3.0 doesn't have this fix included

il...@google.com <il...@google.com> #11Aug 18, 2020 08:47PM

Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.