Fixed
Status Update
Comments
il...@google.com <il...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
[Deleted User] <[Deleted User]> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
ap...@google.com <ap...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.tv:tv-material:1.0.0-alpha04
il...@google.com <il...@google.com> #6
We've fixed this internally and it'll be available in Navigation 2.3.0-alpha05. We're still evaluating a potential 2.2.X release (which would include this release if we did one).
[Deleted User] <[Deleted User]> #7
Thanks!
an...@google.com <an...@google.com> #8
il...@google.com <il...@google.com> #9
We've decided to release a Navigation 2.2.3 bug fix release and will be including this change in that release.
dk...@fundrise.com <dk...@fundrise.com> #10
Guys, 2.3.0 doesn't have this fix included
il...@google.com <il...@google.com> #11
Re #10 - it definitely does. Please file a new issue with a sample project that reproduces any issue you're having with Navigation 2.3.0.
Description
Component used: Navigation
Version used: 2.2.2
Devices/Android versions reproduced on: Emulator Android R, OnePlus 7 with Android 10
The issue appeared in 2.2.2, 2.2.1 works just fine. Error log:
This log appears TWICE, so both graphs failed while lookup. In version 2.2.1 this log appeared once, as expected, for the nested graph.
The issue here is that in
main_navigation
i have other navigation graph for intro flow (splash screen, onboarding etc). If in main_navigation i have only fragments - everything works fineScenario to reproduce problem on attached project
Pending intent in notification should point to main page, but it can't. Why? Because method
findInvalidDestinationDisplayNameInDeepLink
is looking for deep link handler twice. Once in propermain_navigation
. But the second time - it is looking for it inintro_navigation
, which doesn't have destination we are looking for. The changed line that broke things isgraph.findNode(destinationId, false);
. And it seems reasonable to me -intro_navigation
can't find proper node, but it's parent can. I can confirm that evaluatinggraph.findNode(destinationId, true);
returns proper node which is expected behavior.Please ask if i can provide you with more information. Full reproduction sample provided.